Commit c2847bbc by Tom Anderson Committed by Commit Bot

[GLX] Don't request exposure events for child windows

After [1], Chrome and ANGLE use separate X11 connections, so in order for Chrome to receive exposure events, it must select for them its own connection, which is done in [2]. The events selected by ANGLE's connection are never dispatched, so they queue up indefinitely and leak until the connection is closed (when happens when Chrome closes). This change removes the request to receive exposure events. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2492177 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2602441 Change-Id: Ie47c3700855aeeecc8efa1b379df60c344b1b70a Bug: chromium:1158170 R=jonahr Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602705Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
parent 095fd1d3
...@@ -117,7 +117,6 @@ egl::Error WindowSurfaceGLX::initialize(const egl::Display *display) ...@@ -117,7 +117,6 @@ egl::Error WindowSurfaceGLX::initialize(const egl::Display *display)
mGLXWindow = mGLX.createWindow(mFBConfig, mWindow, nullptr); mGLXWindow = mGLX.createWindow(mFBConfig, mWindow, nullptr);
XMapWindow(mDisplay, mWindow); XMapWindow(mDisplay, mWindow);
XSelectInput(mDisplay, mWindow, ExposureMask); // For XExposeEvent forwarding from child window
XFlush(mDisplay); XFlush(mDisplay);
XFree(visualInfo); XFree(visualInfo);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment