Commit c3b57529 by Geoff Lang

Revert "EGLContextCompatibility: suppress test on Linux non-standalone"

Causing gyp generation failures on FYI bots: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder/builds/30490 This reverts commit af98f24a. Change-Id: I0b3ea26ee02591588bda14676211658b42135cf2 Reviewed-on: https://chromium-review.googlesource.com/284910Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Tested-by: 's avatarGeoff Lang <geofflang@chromium.org>
parent af98f24a
...@@ -53,13 +53,6 @@ ...@@ -53,13 +53,6 @@
'<(windows_sdk_path)/Include/um', '<(windows_sdk_path)/Include/um',
], ],
}], }],
['angle_standalone==1',
{
'defines':
[
'ANGLE_STANDALONE_BUILD',
],
}],
], ],
'msvs_settings': 'msvs_settings':
{ {
......
...@@ -175,6 +175,15 @@ class EGLContextCompatibilityTest : public ANGLETest ...@@ -175,6 +175,15 @@ class EGLContextCompatibilityTest : public ANGLETest
eglMakeCurrent(mDisplay, surface, surface, context); eglMakeCurrent(mDisplay, surface, surface, context);
ASSERT_EGL_SUCCESS(); ASSERT_EGL_SUCCESS();
#ifdef ANGLE_PLATFORM_LINUX
// TODO(cwallez): figure out why this is broken on Linux/AMD.
if (isAMD() && getPlatformRenderer() == EGL_PLATFORM_ANGLE_TYPE_OPENGL_ANGLE)
{
eglMakeCurrent(mDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);
return;
}
#endif
glViewport(0, 0, 500, 500); glViewport(0, 0, 500, 500);
glClearColor(0.0f, 0.0f, 1.0f, 1.0f); glClearColor(0.0f, 0.0f, 1.0f, 1.0f);
glClear(GL_COLOR_BUFFER_BIT); glClear(GL_COLOR_BUFFER_BIT);
...@@ -192,9 +201,6 @@ class EGLContextCompatibilityTest : public ANGLETest ...@@ -192,9 +201,6 @@ class EGLContextCompatibilityTest : public ANGLETest
} }
}; };
// TODO(cwallez) makeCurrent fails for some config on Linux/AMD
#if !defined(ANGLE_PLATFORM_LINUX) || defined(ANGLE_STANDALONE_BUILD)
// The test is split in several subtest so that simple cases // The test is split in several subtest so that simple cases
// are tested separately. Also each surface types are not tested // are tested separately. Also each surface types are not tested
// together. // together.
...@@ -285,6 +291,4 @@ TEST_P(EGLContextCompatibilityTest, PbufferDifferentConfig) ...@@ -285,6 +291,4 @@ TEST_P(EGLContextCompatibilityTest, PbufferDifferentConfig)
} }
} }
#endif // !defined(ANGLE_PLATFORM_LINUX) || defined(ANGLE_STANDALONE_BUILD)
ANGLE_INSTANTIATE_TEST(EGLContextCompatibilityTest, ES2_D3D9(), ES2_D3D11(), ES2_OPENGL()); ANGLE_INSTANTIATE_TEST(EGLContextCompatibilityTest, ES2_D3D9(), ES2_D3D11(), ES2_OPENGL());
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment