Commit c6faa974 by Yuly Novikov Committed by Commit Bot

Skip UniformBufferTest.SimpleBindingChange on Mac NVIDIA GL

Unskip UniformBufferTest.SimpleBufferChange, which was skipped by mistake instead of this test in https://chromium-review.googlesource.com/833287 BUG=angleproject:2287 Change-Id: Id79821b26ad38ed07d1193b717ad222df3bb58fe Reviewed-on: https://chromium-review.googlesource.com/838262Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
parent 0c37100d
...@@ -1414,6 +1414,9 @@ void main() ...@@ -1414,6 +1414,9 @@ void main()
// Regression test for a dirty bit bug in ANGLE. See http://crbug.com/792966 // Regression test for a dirty bit bug in ANGLE. See http://crbug.com/792966
TEST_P(UniformBufferTest, SimpleBindingChange) TEST_P(UniformBufferTest, SimpleBindingChange)
{ {
// http://anglebug.com/2287
ANGLE_SKIP_TEST_IF(IsOSX() && IsNVIDIA() && IsDesktopOpenGL());
ANGLE_GL_PROGRAM(program, kVertexShader, kFragmentShader); ANGLE_GL_PROGRAM(program, kVertexShader, kFragmentShader);
glBindAttribLocation(program, 0, "a_vertex"); glBindAttribLocation(program, 0, "a_vertex");
...@@ -1459,9 +1462,6 @@ TEST_P(UniformBufferTest, SimpleBindingChange) ...@@ -1459,9 +1462,6 @@ TEST_P(UniformBufferTest, SimpleBindingChange)
// Regression test for a dirty bit bug in ANGLE. Same as above but for the indexed bindings. // Regression test for a dirty bit bug in ANGLE. Same as above but for the indexed bindings.
TEST_P(UniformBufferTest, SimpleBufferChange) TEST_P(UniformBufferTest, SimpleBufferChange)
{ {
// anglebug.com/2287
ANGLE_SKIP_TEST_IF(IsOSX() && IsNVIDIA() && IsDesktopOpenGL());
ANGLE_GL_PROGRAM(program, kVertexShader, kFragmentShader); ANGLE_GL_PROGRAM(program, kVertexShader, kFragmentShader);
glBindAttribLocation(program, 0, "a_vertex"); glBindAttribLocation(program, 0, "a_vertex");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment