Commit c84e20ee by Geoff Lang

Revert "Add a flush before looping to get the sync status."

Apparently even a flush isn't enough on some Intel drivers. This reverts commit 73410e42. Change-Id: Iafdd1cbb4e89d30ebe3be6404f0bf4e586d91b8d Reviewed-on: https://chromium-review.googlesource.com/275305Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Tested-by: 's avatarGeoff Lang <geofflang@chromium.org>
parent b07aba07
......@@ -230,6 +230,13 @@ TEST_P(FenceSyncTest, BasicQueries)
// Test that basic usage works and doesn't generate errors or crash
TEST_P(FenceSyncTest, BasicOperations)
{
// TODO(geofflang): Figure out why this is broken on Intel OpenGL
if (isIntel() && getPlatformRenderer() == EGL_PLATFORM_ANGLE_TYPE_OPENGL_ANGLE)
{
std::cout << "Test skipped on Intel OpenGL." << std::endl;
return;
}
glClearColor(1.0f, 0.0f, 1.0f, 1.0f);
GLsync sync = glFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0);
......@@ -238,10 +245,6 @@ TEST_P(FenceSyncTest, BasicOperations)
glWaitSync(sync, 0, GL_TIMEOUT_IGNORED);
EXPECT_GL_NO_ERROR();
// Some drivers don't automatically flush and can enter into an infinite loop
// while waiting for the fence to complete.
glFlush();
GLsizei length = 0;
GLint value = 0;
while (value != GL_SIGNALED)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment