Commit cb1a3ce5 by Jamie Madill Committed by Commit Bot

Skia Gold: Fix Android stdout parsing.

A recent change in Chromium broke how we were parsing stdout for capturing system info on Android. Fix the break and also update some helper scripts to work better when run manually. Bug: angleproject:5261 Change-Id: Iecc00bbe540461ab50ea31b5245b8b38a7250956 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507633Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 68b95b63
...@@ -182,7 +182,7 @@ def get_skia_gold_keys(args): ...@@ -182,7 +182,7 @@ def get_skia_gold_keys(args):
def append(self, line): def append(self, line):
if self.done_accepting_lines: if self.done_accepting_lines:
return return
if 'android/test_runner.py' in line: if 'Additional test environment' in line or 'android/test_runner.py' in line:
self.accepting_lines = False self.accepting_lines = False
self.is_android = True self.is_android = True
if ANDROID_BEGIN_SYSTEM_INFO in line: if ANDROID_BEGIN_SYSTEM_INFO in line:
......
File mode changed from 100644 to 100755
...@@ -3,7 +3,18 @@ ...@@ -3,7 +3,18 @@
# found in the LICENSE file. # found in the LICENSE file.
"""ANGLE implementation of //build/skia_gold_common/skia_gold_properties.py.""" """ANGLE implementation of //build/skia_gold_common/skia_gold_properties.py."""
import os
import sys
import subprocess import subprocess
import sys
d = os.path.dirname
THIS_DIR = d(os.path.abspath(__file__))
ANGLE_SRC_DIR = d(d(d(d(THIS_DIR))))
sys.path.insert(0, os.path.join(ANGLE_SRC_DIR, 'build'))
CHROMIUM_SRC_DIR = d(d(ANGLE_SRC_DIR))
sys.path.insert(0, os.path.join(CHROMIUM_SRC_DIR, 'build'))
from skia_gold_common import skia_gold_properties from skia_gold_common import skia_gold_properties
......
...@@ -3,6 +3,16 @@ ...@@ -3,6 +3,16 @@
# found in the LICENSE file. # found in the LICENSE file.
"""ANGLE implementation of //build/skia_gold_common/skia_gold_session.py.""" """ANGLE implementation of //build/skia_gold_common/skia_gold_session.py."""
import os
import sys
d = os.path.dirname
THIS_DIR = d(os.path.abspath(__file__))
ANGLE_SRC_DIR = d(d(d(d(THIS_DIR))))
sys.path.insert(0, os.path.join(ANGLE_SRC_DIR, 'build'))
CHROMIUM_SRC_DIR = d(d(ANGLE_SRC_DIR))
sys.path.insert(0, os.path.join(CHROMIUM_SRC_DIR, 'build'))
from skia_gold_common import output_managerless_skia_gold_session as omsgs from skia_gold_common import output_managerless_skia_gold_session as omsgs
......
...@@ -3,6 +3,16 @@ ...@@ -3,6 +3,16 @@
# found in the LICENSE file. # found in the LICENSE file.
"""ANGLE implementation of //build/skia_gold_common/skia_gold_session_manager.py.""" """ANGLE implementation of //build/skia_gold_common/skia_gold_session_manager.py."""
import os
import sys
d = os.path.dirname
THIS_DIR = d(os.path.abspath(__file__))
ANGLE_SRC_DIR = d(d(d(d(THIS_DIR))))
sys.path.insert(0, os.path.join(ANGLE_SRC_DIR, 'build'))
CHROMIUM_SRC_DIR = d(d(ANGLE_SRC_DIR))
sys.path.insert(0, os.path.join(CHROMIUM_SRC_DIR, 'build'))
from skia_gold_common import skia_gold_session_manager as sgsm from skia_gold_common import skia_gold_session_manager as sgsm
import angle_skia_gold_session import angle_skia_gold_session
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment