Commit cbbf9587 by Courtney Goeltzenleuchter Committed by Commit Bot

Fix ASAN issue with accessing application name

ASAN caught reference outside scope issue regarding RendererVk::initialize. Need to have a local copy of the string so that it stays alive for the Vulkan call. Bug: b/168145220 Change-Id: I13d751a48fe86a5a3d603d892c86c5a7186f2606 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2402353Reviewed-by: 's avatarIan Elliott <ianelliott@google.com> Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
parent 9a7b0a2d
...@@ -690,7 +690,8 @@ angle::Result RendererVk::initialize(DisplayVk *displayVk, ...@@ -690,7 +690,8 @@ angle::Result RendererVk::initialize(DisplayVk *displayVk,
VkApplicationInfo applicationInfo = {}; VkApplicationInfo applicationInfo = {};
applicationInfo.sType = VK_STRUCTURE_TYPE_APPLICATION_INFO; applicationInfo.sType = VK_STRUCTURE_TYPE_APPLICATION_INFO;
applicationInfo.pApplicationName = angle::GetExecutableName().c_str(); std::string appName = angle::GetExecutableName();
applicationInfo.pApplicationName = appName.c_str();
applicationInfo.applicationVersion = 1; applicationInfo.applicationVersion = 1;
applicationInfo.pEngineName = "ANGLE"; applicationInfo.pEngineName = "ANGLE";
applicationInfo.engineVersion = 1; applicationInfo.engineVersion = 1;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment