Vulkan: Handle GL_MAP_PERSISTENT_BIT_EXT for external buffer

When user specifies GL_MAP_PERSISTENT_BIT_EXT bit for an external buffer but we are unable to import it into a memoryType that supports host visibility, error out with GL_INVALID_OPERATION error. Bug: angleproject:5073 Bug: angleproject:5909 Change-Id: I03e5477266dfb705bfb0a1bce5ca003049ef4c7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862560 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Vulkan: Handle GL_MAP_PERSISTENT_BIT_EXT for external buffer
cc3e7b5d · Mohan Maiya · Commit Bot · eb6548bb · cc3e7b5d
Commit cc3e7b5d authored Apr 26, 2021 by Mohan Maiya Committed by Commit Bot May 06, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 1 deletion

BufferVk.cpp src/libANGLE/renderer/vulkan/BufferVk.cpp +10 -1

No files found.
--- a/src/libANGLE/renderer/vulkan/BufferVk.cpp
+++ b/src/libANGLE/renderer/vulkan/BufferVk.cpp
@@ -293,7 +293,16 @@ angle::Result BufferVk::setDataWithUsageFlags(const gl::Context *context,

    if (isExternalBuffer)
    {
-        return setExternalBufferData(context, target, clientBuffer, size, memoryPropertyFlags);
+        ANGLE_TRY(setExternalBufferData(context, target, clientBuffer, size, memoryPropertyFlags));
+        if (!mBuffer->isHostVisible())
+        {
+            // If external buffer's memory does not support host visible memory property, we cannot
+            // support a persistent map request.
+            ANGLE_VK_CHECK(vk::GetImpl(context), !persistentMapRequired,
+                           VK_ERROR_MEMORY_MAP_FAILED);
+        }
+
+        return angle::Result::Continue;
    }
    return setDataWithMemoryType(context, target, data, size, memoryPropertyFlags,
                                 persistentMapRequired);