Don't initialize textures on SubImage calls if the whole image will be filled.

BUG=angleproject:2107 BUG=angleproject:2196 Change-Id: I3e7e78bfc64f1683921af2e48fe20c7be0b85af3 Reviewed-on: https://chromium-review.googlesource.com/734228 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Don't initialize textures on SubImage calls if the whole image will be filled.
cc4ce4a2 · Geoff Lang · Commit Bot · 815a6c9a · cc4ce4a2
Commit cc4ce4a2 authored Oct 23, 2017 by Geoff Lang Committed by Commit Bot Oct 23, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 2 deletions

Texture.cpp src/libANGLE/Texture.cpp +9 -2

No files found.
--- a/src/libANGLE/Texture.cpp
+++ b/src/libANGLE/Texture.cpp
@@ -1446,9 +1446,16 @@ Error Texture::ensureSubImageInitialized(const Context *context,
    // Pre-initialize the texture contents if necessary.
    // TODO(jmadill): Check if area overlaps the entire texture.
    const auto &imageIndex = GetImageIndexFromDescIndex(target, level);
-    if (initState(imageIndex) == InitState::MayNeedInit)
+    const auto &desc       = mState.getImageDesc(imageIndex);
+    if (desc.initState == InitState::MayNeedInit)
    {
-        ANGLE_TRY(initializeContents(context, imageIndex));
+        bool coversWholeImage = area.x == 0 && area.y == 0 && area.z == 0 &&
+                                area.width == desc.size.width && area.height == desc.size.height &&
+                                area.depth == desc.size.depth;
+        if (!coversWholeImage)
+        {
+            ANGLE_TRY(initializeContents(context, imageIndex));
+        }
        setInitState(imageIndex, InitState::Initialized);
    }