Reset binding offset & size when unbinding

Bug: angleproject:4147 Change-Id: I4ace1221d32631cdb14a95c71ee9a1617837a5ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1970495Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

Reset binding offset & size when unbinding
cd129d17 · Courtney Goeltzenleuchter · Commit Bot · 17b3c2f3 · cd129d17 · cd129d17
Commit cd129d17 authored Dec 16, 2019 by Courtney Goeltzenleuchter Committed by Commit Bot Dec 18, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 5 deletions

RefCountObject.h src/libANGLE/RefCountObject.h +10 -2

deqp_khr_gles31_test_expectations.txt src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt +0 -3

No files found.
--- a/src/libANGLE/RefCountObject.h
+++ b/src/libANGLE/RefCountObject.h
@@ -203,8 +203,16 @@ class OffsetBindingPointer : public BindingPointer<ObjectType>
    void assign(ObjectType *object, GLintptr offset, GLsizeiptr size)
    {
        assign(object);
-        mOffset = offset;
-        mSize   = size;
+        if (object)
+        {
+            mOffset = offset;
+            mSize   = size;
+        }
+        else
+        {
+            mOffset = 0;
+            mSize   = 0;
+        }
    }

  private:

--- a/src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt
+++ b/src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt
@@ -86,9 +86,6 @@
 4128 VULKAN NVIDIA : KHR-GLES31.core.shader_storage_buffer_object.advanced-unsizedArrayLength-vs-*-matR* = SKIP
 4128 VULKAN NVIDIA : KHR-GLES31.core.shader_storage_buffer_object.advanced-unsizedArrayLength-fs-*-matR* = SKIP

-// Bug with binding the zero buffer and glBindBufferRange:
-4147 : KHR-GLES31.core.shader_storage_buffer_object.basic-binding = FAIL
-
 // Error with detecting some atomic counter buffer uses:
 4150 : KHR-GLES31.core.shader_storage_buffer_object.basic-atomic-case3-cs = FAIL
 4150 : KHR-GLES31.core.shader_storage_buffer_object.basic-atomic-case3-vsfs = FAIL