Skip to content

A
angle
Commit cd6028de by Nico Weber Committed by Commit Bot
Options

Suppress two -Wunreachable-code warnings on Fuchsia in Angle.

Bug: chromium:346399 Change-Id: Ibf9cefdee52e487d9e73b9dff98a12267ac82af6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112281 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 4fb3c28f
Showing with 4 additions and 8 deletions
src/common/system_utils_unittest.cpp
...@@ -17,29 +17,25 @@ namespace ...@@ -17,29 +17,25 @@ namespace
// Test getting the executable path // Test getting the executable path
TEST(SystemUtils, ExecutablePath) TEST(SystemUtils, ExecutablePath)
{ {
#if defined(ANGLE_PLATFORM_FUCHSIA)
// TODO: fuchsia support. http://anglebug.com/3161 // TODO: fuchsia support. http://anglebug.com/3161
return; #if !defined(ANGLE_PLATFORM_FUCHSIA)
#endif
std::string executablePath = GetExecutablePath(); std::string executablePath = GetExecutablePath();
EXPECT_NE("", executablePath); EXPECT_NE("", executablePath);
#endif
} }
// Test getting the executable directory // Test getting the executable directory
TEST(SystemUtils, ExecutableDir) TEST(SystemUtils, ExecutableDir)
{ {
#if defined(ANGLE_PLATFORM_FUCHSIA)
// TODO: fuchsia support. http://anglebug.com/3161 // TODO: fuchsia support. http://anglebug.com/3161
return; #if !defined(ANGLE_PLATFORM_FUCHSIA)
#endif
std::string executableDir = GetExecutableDirectory(); std::string executableDir = GetExecutableDirectory();
EXPECT_NE("", executableDir); EXPECT_NE("", executableDir);
std::string executablePath = GetExecutablePath(); std::string executablePath = GetExecutablePath();
EXPECT_LT(executableDir.size(), executablePath.size()); EXPECT_LT(executableDir.size(), executablePath.size());
EXPECT_EQ(0, strncmp(executableDir.c_str(), executablePath.c_str(), executableDir.size())); EXPECT_EQ(0, strncmp(executableDir.c_str(), executablePath.c_str(), executableDir.size()));
#endif
} }
// Test setting environment variables // Test setting environment variables
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment