Commit cde4f024 by Qin Jiajia Committed by Commit Bot

Remove unused parameters of StoreStaticAttrib

The parameters count and instances in VertexDataManager::StoreStaticAttrib are never used in the function body. So this patch will remove them. BUG=none Change-Id: Ic3fe21ae50e5016145bfd0c78542540c8ec76fd2 Reviewed-on: https://chromium-review.googlesource.com/445337 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarYunchao He <yunchao.he@intel.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 308d745d
...@@ -256,7 +256,7 @@ gl::Error VertexDataManager::prepareVertexData(const gl::State &state, ...@@ -256,7 +256,7 @@ gl::Error VertexDataManager::prepareVertexData(const gl::State &state,
case VertexStorageType::STATIC: case VertexStorageType::STATIC:
{ {
// Store static attribute. // Store static attribute.
ANGLE_TRY(StoreStaticAttrib(translated, count, instances)); ANGLE_TRY(StoreStaticAttrib(translated));
break; break;
} }
case VertexStorageType::DYNAMIC: case VertexStorageType::DYNAMIC:
...@@ -313,9 +313,7 @@ void VertexDataManager::StoreDirectAttrib(TranslatedAttribute *directAttrib) ...@@ -313,9 +313,7 @@ void VertexDataManager::StoreDirectAttrib(TranslatedAttribute *directAttrib)
} }
// static // static
gl::Error VertexDataManager::StoreStaticAttrib(TranslatedAttribute *translated, gl::Error VertexDataManager::StoreStaticAttrib(TranslatedAttribute *translated)
GLsizei count,
GLsizei instances)
{ {
const auto &attrib = *translated->attribute; const auto &attrib = *translated->attribute;
const auto &binding = *translated->binding; const auto &binding = *translated->binding;
......
...@@ -95,9 +95,7 @@ class VertexDataManager : angle::NonCopyable ...@@ -95,9 +95,7 @@ class VertexDataManager : angle::NonCopyable
static void StoreDirectAttrib(TranslatedAttribute *directAttrib); static void StoreDirectAttrib(TranslatedAttribute *directAttrib);
static gl::Error StoreStaticAttrib(TranslatedAttribute *translated, static gl::Error StoreStaticAttrib(TranslatedAttribute *translated);
GLsizei count,
GLsizei instances);
gl::Error storeDynamicAttribs(std::vector<TranslatedAttribute> *translatedAttribs, gl::Error storeDynamicAttribs(std::vector<TranslatedAttribute> *translatedAttribs,
const gl::AttributesMask &dynamicAttribsMask, const gl::AttributesMask &dynamicAttribsMask,
......
...@@ -165,8 +165,7 @@ gl::Error VertexArray11::updateDirtyAndDynamicAttribs(VertexDataManager *vertexD ...@@ -165,8 +165,7 @@ gl::Error VertexArray11::updateDirtyAndDynamicAttribs(VertexDataManager *vertexD
break; break;
case VertexStorageType::STATIC: case VertexStorageType::STATIC:
{ {
ANGLE_TRY( ANGLE_TRY(VertexDataManager::StoreStaticAttrib(translatedAttrib));
VertexDataManager::StoreStaticAttrib(translatedAttrib, count, instances));
break; break;
} }
case VertexStorageType::CURRENT_VALUE: case VertexStorageType::CURRENT_VALUE:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment