Add finite check to lexer float constants.

The fuzzer was generating cases where floating point constants would someone return as valid when they were beyond max float. I was unable to reproduce this in a standalone test, but confirmed this check fixes the fuzzer error. BUG=660702 Change-Id: I9e6b883958013638ea509e38b30e812a9e74fbc1 Reviewed-on: https://chromium-review.googlesource.com/406268Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Add finite check to lexer float constants.
cfe7b2c4 · Jamie Madill · Commit Bot · d75d03bd · cfe7b2c4
Commit cfe7b2c4 authored Nov 01, 2016 by Jamie Madill Committed by Commit Bot Nov 01, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

numeric_lex.h src/compiler/preprocessor/numeric_lex.h +2 -1

No files found.
--- a/src/compiler/preprocessor/numeric_lex.h
+++ b/src/compiler/preprocessor/numeric_lex.h
@@ -9,6 +9,7 @@
 #ifndef COMPILER_PREPROCESSOR_NUMERICLEX_H_
 #define COMPILER_PREPROCESSOR_NUMERICLEX_H_

+#include <cmath>
 #include <sstream>

 namespace pp {
@@ -63,7 +64,7 @@ bool numeric_lex_float(const std::string &str, FloatType *value)
    stream.imbue(std::locale::classic());

    stream >> (*value);
-    return !stream.fail();
+    return !stream.fail() && std::isfinite(*value);
 #endif
 }