Vulkan: Mark some Resource APIs are protected.

This clarifies what is supposed to be called from outside the class to what should be called internally. The read/write dependency management is accessible publically. The command buffer access however is private and should be only used within the class. Bug: angleproject:2539 Change-Id: Ic25b589d4009de62633d13546be596ecafd0b175 Reviewed-on: https://chromium-review.googlesource.com/1066555 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Luc Ferron <lucferron@chromium.org> Reviewed-by: Frank Henigman <fjhenigman@chromium.org>

Vulkan: Mark some Resource APIs are protected.
d014c9e6 · Jamie Madill · Commit Bot · 5dca651f · d014c9e6
Commit d014c9e6 authored May 18, 2018 by Jamie Madill Committed by Commit Bot May 30, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 6 deletions

CommandGraph.h src/libANGLE/renderer/vulkan/CommandGraph.h +7 -6

No files found.
--- a/src/libANGLE/renderer/vulkan/CommandGraph.h
+++ b/src/libANGLE/renderer/vulkan/CommandGraph.h
@@ -33,6 +33,13 @@ class CommandGraphResource

    Serial getQueueSerial() const;

+    // Sets up dependency relations. 'this' resource is the resource being written to.
+    void addWriteDependency(CommandGraphResource *writingResource);
+
+    // Sets up dependency relations. 'this' resource is the resource being read.
+    void addReadDependency(CommandGraphResource *readingResource);
+
+  protected:
    // Allocates a write node via getNewWriteNode and returns a started command buffer.
    // The started command buffer will render outside of a RenderPass.
    Error beginWriteResource(RendererVk *renderer, CommandBuffer **commandBufferOut);
@@ -64,12 +71,6 @@ class CommandGraphResource
    // Called when 'this' object changes, but we'd like to start a new command buffer later.
    void onResourceChanged(RendererVk *renderer);

-    // Sets up dependency relations. 'this' resource is the resource being written to.
-    void addWriteDependency(CommandGraphResource *writingResource);
-
-    // Sets up dependency relations. 'this' resource is the resource being read.
-    void addReadDependency(CommandGraphResource *readingResource);
-
  private:
    void onWriteImpl(CommandGraphNode *writingNode, Serial currentSerial);