Blendable check

- Added a blendable check to InternalFormat - Set the blendable check to the same as the Renderbuffer check for most formats, except true integer formats and 32F formats - True integer formats never support blending - 32F formats support blending based on the GL_EXT_float_blend Bug: angleproject:4291 Change-Id: Icffdd3e6d8791303bdfdad9ec01cfd9a1d511af0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999495Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>

Blendable check
d151b459 · Alexis Hetu · Commit Bot · 441b72f0 · d151b459 · d151b459
Commit d151b459 authored Jan 14, 2020 by Alexis Hetu Committed by Commit Bot Jan 16, 2020
Showing with 4 additions and 0 deletions

Caps.cpp src/libANGLE/Caps.cpp +1 -0

Context.cpp src/libANGLE/Context.cpp +2 -0

formatutils.cpp src/libANGLE/formatutils.cpp +0 -0

formatutils.h src/libANGLE/formatutils.h +1 -0

No files found.
--- a/src/libANGLE/Caps.cpp
+++ b/src/libANGLE/Caps.cpp
@@ -71,6 +71,7 @@ TextureCaps GenerateMinimumTextureCaps(GLenum sizedInternalFormat,
    caps.filterable        = internalFormatInfo.filterSupport(clientVersion, extensions);
    caps.textureAttachment = internalFormatInfo.textureAttachmentSupport(clientVersion, extensions);
    caps.renderbuffer      = internalFormatInfo.renderbufferSupport(clientVersion, extensions);
+    caps.blendable         = internalFormatInfo.blendSupport(clientVersion, extensions);

    caps.sampleCounts.insert(0);
    if (internalFormatInfo.isRequiredRenderbufferFormat(clientVersion))

--- a/src/libANGLE/Context.cpp
+++ b/src/libANGLE/Context.cpp
@@ -3681,6 +3681,8 @@ void Context::updateCaps()
        formatCaps.renderbuffer =
            formatCaps.renderbuffer &&
            formatInfo.renderbufferSupport(getClientVersion(), mState.mExtensions);
+        formatCaps.blendable =
+            formatCaps.blendable && formatInfo.blendSupport(getClientVersion(), mState.mExtensions);

        // OpenGL ES does not support multisampling with non-rendererable formats
        // OpenGL ES 3.0 or prior does not support multisampling with integer formats

--- a/src/libANGLE/formatutils.cpp
+++ b/src/libANGLE/formatutils.cpp
--- a/src/libANGLE/formatutils.h
+++ b/src/libANGLE/formatutils.h
@@ -224,6 +224,7 @@ struct InternalFormat
    SupportCheckFunction filterSupport;
    SupportCheckFunction textureAttachmentSupport;  // glFramebufferTexture2D
    SupportCheckFunction renderbufferSupport;       // glFramebufferRenderbuffer
+    SupportCheckFunction blendSupport;
 };

 // A "Format" wraps an InternalFormat struct, querying it from either a sized internal format or