Fix ASAN issue with FastIntegerMap.BasicUsage

ASAN bot caught bug in FastIntegerMap.BasicUsage test. The end() iterator points past the end of the list, accessing end()->first is invalid. rbegin() points at the last element of the list which is what this test intended. Bug: b/166255370 Change-Id: I06e098143d3de9658088cda6f10761d41b17a520 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375305Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

Fix ASAN issue with FastIntegerMap.BasicUsage
d19c08c9 · Courtney Goeltzenleuchter · Commit Bot · 33f8e4d4 · d19c08c9
Commit d19c08c9 authored Aug 25, 2020 by Courtney Goeltzenleuchter Committed by Commit Bot Aug 25, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

FastVector_unittest.cpp src/common/FastVector_unittest.cpp +1 -1

No files found.
--- a/src/common/FastVector_unittest.cpp
+++ b/src/common/FastVector_unittest.cpp
@@ -334,7 +334,7 @@ TEST(FastIntegerMap, BasicUsage)
    std::string str;
    testMap.insert(entries.begin()->first, entries.begin()->second);
    EXPECT_TRUE(testMap.contains(entries.begin()->first));
-    EXPECT_FALSE(testMap.contains(entries.end()->first));
+    EXPECT_FALSE(testMap.contains(entries.rbegin()->first));
    EXPECT_FALSE(testMap.empty());
    EXPECT_EQ(testMap.size(), 1u);
    EXPECT_TRUE(testMap.get(entries.begin()->first, &str));