Commit d364780a by Yuly Novikov Committed by Commit Bot

Skip ReadPixelsTest.OutOfBounds on Adreno Android GLES

Due to Adreno bug in glReadPixels BUG=angleproject:1413 TEST=ReadPixelsTest.OutOfBounds Change-Id: I2fd426bc6d21f5d9604ca32ad34dd8841cbb9a3e Reviewed-on: https://chromium-review.googlesource.com/353363Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
parent 438dbcf1
......@@ -35,6 +35,13 @@ class ReadPixelsTest : public ANGLETest
// Test out of bounds reads.
TEST_P(ReadPixelsTest, OutOfBounds)
{
// TODO: re-enable once root cause of http://anglebug.com/1413 is fixed
if (IsAndroid() && IsAdreno() && isGLES())
{
std::cout << "Test skipped on Adreno OpenGLES on Android." << std::endl;
return;
}
glClearColor(1.0f, 0.0f, 0.0f, 1.0f);
glClear(GL_COLOR_BUFFER_BIT);
EXPECT_GL_NO_ERROR();
......
......@@ -662,6 +662,12 @@ bool IsIntel()
return (rendererString.find("Intel") != std::string::npos);
}
bool IsAdreno()
{
std::string rendererString(reinterpret_cast<const char *>(glGetString(GL_RENDERER)));
return (rendererString.find("Adreno") != std::string::npos);
}
bool IsAMD()
{
std::string rendererString(reinterpret_cast<const char *>(glGetString(GL_RENDERER)));
......@@ -698,6 +704,15 @@ bool IsD3DSM3()
return IsD3D9() || IsD3D11_FL93();
}
bool IsAndroid()
{
#if defined(ANGLE_PLATFORM_ANDROID)
return true;
#else
return false;
#endif
}
bool IsLinux()
{
#if defined(ANGLE_PLATFORM_LINUX)
......
......@@ -235,6 +235,7 @@ class ANGLETestEnvironment : public testing::Environment
};
bool IsIntel();
bool IsAdreno();
bool IsAMD();
bool IsNVIDIA();
// Note: FL9_3 is explicitly *not* considered D3D11.
......@@ -244,6 +245,7 @@ bool IsD3D11_FL93();
bool IsD3D9();
// Is D3D9 or SM9_3 renderer.
bool IsD3DSM3();
bool IsAndroid();
bool IsLinux();
bool IsOSX();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment