Skip to content

A
angle
Commit d38b9f86 by Cody Northrop Committed by Commit Bot
Options

Allow GL_OES_shader_image_atomic when non-conformant

On Android, force allowing it with: adb shell setprop debug.angle.feature_overrides_enabled \ exposeNonConformantExtensionsAndVersions If enabling multiple features, switch to using settings which don't have a character limit, but persist across reboots: adb shell settings put global angle_egl_features \ exposeNonConformantExtensionsAndVersions:foo:bar Test: Fortnite on ANGLE Bug: b/170755560 Bug: angleproject:5503 Change-Id: I58e3b265daa8ea1f645f47e0971c4454b8ddb3f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2570775 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
parent fb4eea2e
Showing with 6 additions and 1 deletion
src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
...@@ -912,7 +912,8 @@ void RendererVk::ensureCapsInitialized() const ...@@ -912,7 +912,8 @@ void RendererVk::ensureCapsInitialized() const
// imageAtomicExchange supports r32f. Exposing this extension is thus restricted to this format // imageAtomicExchange supports r32f. Exposing this extension is thus restricted to this format
// having support for the aforementioned features. // having support for the aforementioned features.
mNativeExtensions.shaderImageAtomicOES = mNativeExtensions.shaderImageAtomicOES =
vk::HasShaderImageAtomicsSupport(this, mNativeExtensions); vk::HasShaderImageAtomicsSupport(this, mNativeExtensions) ||
getFeatures().exposeNonConformantExtensionsAndVersions.enabled;
// Geometry shader is optional. // Geometry shader is optional.
if (mPhysicalDeviceFeatures.geometryShader) if (mPhysicalDeviceFeatures.geometryShader)
......
src/tests/deqp_support/deqp_gles31_test_expectations.txt
...@@ -343,3 +343,7 @@ ...@@ -343,3 +343,7 @@
3588 VULKAN ANDROID : dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_*_1 = FAIL 3588 VULKAN ANDROID : dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_*_1 = FAIL
3588 VULKAN ANDROID : dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_*_2 = FAIL 3588 VULKAN ANDROID : dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_*_2 = FAIL
3588 VULKAN ANDROID : dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_*_4 = FAIL 3588 VULKAN ANDROID : dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_*_4 = FAIL
// When ANGLE allows non-conformant features, imageAtomicExchange with r32f fails
5503 VULKAN ANDROID : dEQP-GLES31.functional.image_load_store.*.atomic.exchange_r32f* = FAIL
5503 SWIFTSHADER : dEQP-GLES31.functional.image_load_store.*.atomic.exchange_r32f* = SKIP
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment