Capture/Replay: Ignore deletes of buffer 0

Per the spec for DeleteBuffers: > Unused names in buffers are silently ignored, as is the value zero. Haven't seen an app delete unknown buffers yet, but just hit one that deletes 0 a lot. Test: MEC for Disney Tsum Tsum Bug: b/184770989 Bug: angleproject:5835 Change-Id: I2070b753d89fdcf390203072cd7ec2c9f915089c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2811643 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Capture/Replay: Ignore deletes of buffer 0
d49f7351 · Cody Northrop · Commit Bot · efc53d0f · d49f7351
Commit d49f7351 authored Apr 07, 2021 by Cody Northrop Committed by Commit Bot Apr 07, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

FrameCapture.cpp src/libANGLE/capture/FrameCapture.cpp +7 -1

No files found.
--- a/src/libANGLE/capture/FrameCapture.cpp
+++ b/src/libANGLE/capture/FrameCapture.cpp
@@ -3969,7 +3969,7 @@ void FrameCapture::maybeCapturePreCallUpdates(const gl::Context *context, CallCa
                {
                    mBufferDataMap.erase(bufferDataInfo);
                }
-                // If we're capturing, track what new buffers have been genned
+                // If we're capturing, track what buffers have been deleted
                if (mFrameIndex >= mCaptureStartFrame)
                {
                    mResourceTracker.setDeletedBuffer(bufferIDs[i]);
@@ -4531,6 +4531,12 @@ ResourceTracker::~ResourceTracker() = default;
 void ResourceTracker::setDeletedBuffer(gl::BufferID id)
 {
+    if (id.value == 0)
+    {
+        // Ignore buffer ID 0
+        return;
+    }
    if (mNewBuffers.find(id) != mNewBuffers.end())
    {
        // This is a buffer genned after MEC was initialized, just clear it, since there will be no