Fix unnecessary copy of for loop variables in ANGLE

src/compiler/preprocessor/MacroExpander.cpp

@@ -74,7 +74,7 @@ MacroExpander::ScopedMacroReenabler::ScopedMacroReenabler(MacroExpander *expande
 MacroExpander::ScopedMacroReenabler::~ScopedMacroReenabler()
 {
     mExpander->mDeferReenablingMacros = false;
-    for (auto macro : mExpander->mMacrosToReenable)
+    for (const std::shared_ptr<Macro> &macro : mExpander->mMacrosToReenable)
     {
         // Copying the string here by using substr is a check for use-after-free. It detects
         // use-after-free more reliably than just toggling the disabled flag.

src/compiler/translator/Compiler.cpp

@@ -1095,9 +1095,9 @@ bool TCompiler::checkCallDepth()
     for (size_t i = 0; i < mCallDag.size(); i++)
     {
         int depth    = 0;
-        auto &record = mCallDag.getRecordFromIndex(i);
+        const CallDAG::Record &record = mCallDag.getRecordFromIndex(i);
 
-        for (auto &calleeIndex : record.callees)
+        for (const int &calleeIndex : record.callees)
         {
             depth = std::max(depth, depths[calleeIndex] + 1);
         }
@@ -1122,7 +1122,7 @@ bool TCompiler::checkCallDepth()
                     << mCallDag.getRecordFromIndex(currentFunction).node->getFunction()->name();
 
                 int nextFunction = -1;
-                for (auto &calleeIndex : mCallDag.getRecordFromIndex(currentFunction).callees)
+                for (const int &calleeIndex : mCallDag.getRecordFromIndex(currentFunction).callees)
                 {
                     if (depths[calleeIndex] == currentDepth - 1)
                     {
@@ -1273,7 +1273,7 @@ void TCompiler::useAllMembersInUnusedStandardAndSharedBlocks(TIntermBlock *root)
 {
     sh::InterfaceBlockList list;
 
-    for (auto block : mUniformBlocks)
+    for (const sh::InterfaceBlock &block : mUniformBlocks)
     {
         if (!block.staticUse &&
             (block.layout == sh::BLOCKLAYOUT_STD140 || block.layout == sh::BLOCKLAYOUT_SHARED))
@@ -1290,7 +1290,7 @@ void TCompiler::initializeOutputVariables(TIntermBlock *root)
     InitVariableList list;
     if (mShaderType == GL_VERTEX_SHADER || mShaderType == GL_GEOMETRY_SHADER_EXT)
     {
-        for (auto var : mOutputVaryings)
+        for (const sh::Varying &var : mOutputVaryings)
         {
             list.push_back(var);
             if (var.name == "gl_Position")
@@ -1303,7 +1303,7 @@ void TCompiler::initializeOutputVariables(TIntermBlock *root)
     else
     {
         ASSERT(mShaderType == GL_FRAGMENT_SHADER);
-        for (auto var : mOutputVariables)
+        for (const sh::OutputVariable &var : mOutputVariables)
         {
             list.push_back(var);
         }

src/libANGLE/Program.cpp

@@ -194,7 +194,7 @@ bool IncludeSameArrayElement(const std::set<std::string> &nameSet, const std::st
 {
     std::vector<unsigned int> subscripts;
     std::string baseName = ParseResourceName(name, &subscripts);
-    for (auto nameInSet : nameSet)
+    for (const std::string &nameInSet : nameSet)
     {
         std::vector<unsigned int> arrayIndices;
         std::string arrayName = ParseResourceName(nameInSet, &arrayIndices);
@@ -1449,7 +1449,7 @@ void ProgramState::updateTransformFeedbackStrides()
     {
         mTransformFeedbackStrides.resize(1);
         size_t totalSize = 0;
-        for (auto &varying : mLinkedTransformFeedbackVaryings)
+        for (const TransformFeedbackVarying &varying : mLinkedTransformFeedbackVaryings)
         {
             totalSize += varying.size() * VariableExternalSize(varying.type);
         }
@@ -1460,7 +1460,7 @@ void ProgramState::updateTransformFeedbackStrides()
         mTransformFeedbackStrides.resize(mLinkedTransformFeedbackVaryings.size());
         for (size_t i = 0; i < mLinkedTransformFeedbackVaryings.size(); i++)
         {
-            auto &varying = mLinkedTransformFeedbackVaryings[i];
+            TransformFeedbackVarying &varying = mLinkedTransformFeedbackVaryings[i];
             mTransformFeedbackStrides[i] =
                 static_cast<GLsizei>(varying.size() * VariableExternalSize(varying.type));
         }