Skip to content

A
angle
Commit d50521fd by Ian Elliott Committed by Commit Bot
Options

Only enable VK_KHR_maintenance1 when available.

This prevents an error in case ANGLE is run on an older Vulkan driver that does not support the VK_KHR_maintenance1 extension. Bug: angleproject:3035 Change-Id: I7e2b74bcb88bffdfc2a525a1d332eb3ef7d23d7c Reviewed-on: https://chromium-review.googlesource.com/c/1387347Reviewed-by: 's avatarIan Elliott <ianelliott@google.com> Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org> Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
parent 92b16ea2
Showing with 6 additions and 3 deletions
src/libANGLE/renderer/vulkan/RendererVk.cpp
...@@ -795,9 +795,12 @@ void RendererVk::initFeatures(const std::vector<VkExtensionProperties> &deviceEx ...@@ -795,9 +795,12 @@ void RendererVk::initFeatures(const std::vector<VkExtensionProperties> &deviceEx
mFeatures.basicGLLineRasterization = true; mFeatures.basicGLLineRasterization = true;
#endif // defined(ANGLE_PLATFORM_ANDROID) #endif // defined(ANGLE_PLATFORM_ANDROID)
// TODO(lucferron): Currently disabled on Intel only since many tests are failing and need if (ExtensionFound(VK_KHR_MAINTENANCE1_EXTENSION_NAME, deviceExtensionProps))
// investigation. http://anglebug.com/2728 {
mFeatures.flipViewportY = !IsIntel(mPhysicalDeviceProperties.vendorID); // TODO(lucferron): Currently disabled on Intel only since many tests are failing and need
// investigation. http://anglebug.com/2728
mFeatures.flipViewportY = !IsIntel(mPhysicalDeviceProperties.vendorID);
}
#ifdef ANGLE_PLATFORM_WINDOWS #ifdef ANGLE_PLATFORM_WINDOWS
// http://anglebug.com/2838 // http://anglebug.com/2838
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment