Skip to content

A
angle
Commit d63d0007 by Kai Ninomiya Committed by Commit Bot
Options

dontInitializeUninitializedLocals on Qualcomm only

SH_INITIALIZE_UNINITIALIZED_LOCALS triggers a very unpredictable crash in the shader compiler on Qualcomm Adreno (at least 4xx) on Marshmallow. Bug: angleproject:2046 Change-Id: I9a109f7ff442b4e9d3880d137f1a55a19105bcef Reviewed-on: https://chromium-review.googlesource.com/705930 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 359487c8
Showing with 4 additions and 1 deletion
CONTRIBUTORS
...@@ -41,6 +41,7 @@ Google Inc. ...@@ -41,6 +41,7 @@ Google Inc.
Justin Schuh Justin Schuh
Scott Graham Scott Graham
Corentin Wallez Corentin Wallez
Kai Ninomiya
Adobe Systems Inc. Adobe Systems Inc.
Alexandru Chiculita Alexandru Chiculita
......
src/libANGLE/renderer/gl/renderergl_utils.cpp
...@@ -1067,7 +1067,9 @@ void GenerateWorkarounds(const FunctionsGL *functions, WorkaroundsGL *workaround ...@@ -1067,7 +1067,9 @@ void GenerateWorkarounds(const FunctionsGL *functions, WorkaroundsGL *workaround
#endif #endif
#if defined(ANGLE_PLATFORM_ANDROID) #if defined(ANGLE_PLATFORM_ANDROID)
workarounds->dontInitializeUninitializedLocals = true; // Triggers a bug on Marshmallow Adreno (4xx?) driver.
// http://anglebug.com/2046
workarounds->dontInitializeUninitializedLocals = IsQualcomm(vendor);
#endif #endif
workarounds->finishDoesNotCauseQueriesToBeAvailable = workarounds->finishDoesNotCauseQueriesToBeAvailable =
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment