Skip to content

A
angle
Commit d6d07359 by Jamie Madill Committed by Commit Bot
Options

Fix uninitialize state in ProgramState.

The variable mLocationsUsedForXfbExtension was never initialized which would give it an undefined value for the lifetime of a Program. This was causing the capture replay tests to be very flaky. Bug: angleproject:5248 Change-Id: Id8d61b88fb2ca2c6340acfe9d6e3720378528987 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497562Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent dd2b644a
Showing with 1 addition and 0 deletions
src/libANGLE/Program.cpp
...@@ -1082,6 +1082,7 @@ ProgramState::ProgramState() ...@@ -1082,6 +1082,7 @@ ProgramState::ProgramState()
: mLabel(), : mLabel(),
mAttachedShaders{}, mAttachedShaders{},
mAttachedShadersMarkedForDetach{}, mAttachedShadersMarkedForDetach{},
mLocationsUsedForXfbExtension(0),
mAtomicCounterUniformRange(0, 0), mAtomicCounterUniformRange(0, 0),
mBinaryRetrieveableHint(false), mBinaryRetrieveableHint(false),
mSeparable(false), mSeparable(false),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment