Fix out-of-bounds read in test.

The test wasn't reserving a large enough buffer when initializing the vertex data. Fix the test buffer limits. Bug: angleproject:4430 Change-Id: I4b9a98e1af1cc8088afb871816061d7ee4dd6a2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079153Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Fix out-of-bounds read in test.
da6d12d0 · Jamie Madill · Commit Bot · 698ffd02 · da6d12d0
Commit da6d12d0 authored Feb 27, 2020 by Jamie Madill Committed by Commit Bot Feb 27, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

VertexAttributeTest.cpp src/tests/gl_tests/VertexAttributeTest.cpp +5 -2

No files found.
--- a/src/tests/gl_tests/VertexAttributeTest.cpp
+++ b/src/tests/gl_tests/VertexAttributeTest.cpp
@@ -2530,7 +2530,7 @@ TEST_P(VertexAttributeTestES31, LargeStride)
    RNG rng(0);
-    std::vector<Vertex> vertexData;
+    std::vector<Vertex> vertexData(bufferSize, {Vector4(), Vector2()});
    std::vector<GLColor> expectedColors;
    for (uint32_t vertexIndex = 0; vertexIndex < numVertices; ++vertexIndex)
    {
@@ -2544,7 +2544,8 @@ TEST_P(VertexAttributeTestES31, LargeStride)
        randomColor[3]     = 255;
        Vector4 clampedVec = randomColor.toNormalizedVector();
-        vertexData.push_back({Vector4(x, y, 0.0f, 1.0f), Vector2(clampedVec[0], clampedVec[1])});
+        vertexData[vertexIndex] = {Vector4(x, y, 0.0f, 1.0f),
+                                   Vector2(clampedVec[0], clampedVec[1])};
        expectedColors.push_back(randomColor);
    }
@@ -2552,6 +2553,8 @@ TEST_P(VertexAttributeTestES31, LargeStride)
    glBindBuffer(GL_ARRAY_BUFFER, buffer);
    glBufferData(GL_ARRAY_BUFFER, bufferSize, vertexData.data(), GL_STATIC_DRAW);
+    vertexData.resize(numVertices);
    constexpr char kVS[] = R"(#version 310 es
 in vec4 pos;
 in vec2 color;