Commit daa8c27f by Jamie Madill

Fix a user-after-free in a ValidationES unittest.

The State destructor was trying to unref a Program that had already been deleted. Fix this by unbinding resources from State before we exit the test. BUG=554520 Change-Id: I2215b1e5d27a34a649572c8f81e96dfeef7e983e Reviewed-on: https://chromium-review.googlesource.com/312977 Tryjob-Request: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org> Tested-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 55c25d0c
...@@ -132,6 +132,11 @@ TEST(ValidationESTest, DrawElementsWithMaxIndexGivesError) ...@@ -132,6 +132,11 @@ TEST(ValidationESTest, DrawElementsWithMaxIndexGivesError)
&indexRange)); &indexRange));
texture->release(); texture->release();
state.setVertexArrayBinding(nullptr);
state.setDrawFramebufferBinding(nullptr);
state.setProgram(nullptr);
SafeDelete(vertexArray); SafeDelete(vertexArray);
SafeDelete(framebuffer); SafeDelete(framebuffer);
SafeDelete(program); SafeDelete(program);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment