Commit e076a232 by Geoff Lang Committed by Commit Bot

Vulkan: Fix ReadPixels checking the wrong FBO for flipping.

Only the read framebuffer should affect the flipping for ReadPixels. BUG=angleproject:2673 Change-Id: I3733bb823f5f3ebd55df63a36cc99b510dc0b1aa Reviewed-on: https://chromium-review.googlesource.com/1138817Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
parent 242c4fe8
...@@ -308,7 +308,7 @@ gl::Error FramebufferVk::readPixels(const gl::Context *context, ...@@ -308,7 +308,7 @@ gl::Error FramebufferVk::readPixels(const gl::Context *context,
return gl::NoError(); return gl::NoError();
} }
gl::Rectangle flippedArea = clippedArea; gl::Rectangle flippedArea = clippedArea;
if (contextVk->isViewportFlipEnabledForDrawFBO()) if (contextVk->isViewportFlipEnabledForReadFBO())
{ {
flippedArea.y = fbRect.height - flippedArea.y - flippedArea.height; flippedArea.y = fbRect.height - flippedArea.y - flippedArea.height;
} }
...@@ -319,7 +319,7 @@ gl::Error FramebufferVk::readPixels(const gl::Context *context, ...@@ -319,7 +319,7 @@ gl::Error FramebufferVk::readPixels(const gl::Context *context,
ANGLE_TRY(beginWriteResource(contextVk, &commandBuffer)); ANGLE_TRY(beginWriteResource(contextVk, &commandBuffer));
gl::PixelPackState packState(glState.getPackState()); gl::PixelPackState packState(glState.getPackState());
if (contextVk->isViewportFlipEnabledForDrawFBO()) if (contextVk->isViewportFlipEnabledForReadFBO())
{ {
packState.reverseRowOrder = !packState.reverseRowOrder; packState.reverseRowOrder = !packState.reverseRowOrder;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment