Remove ProgramPipelineState::mHasBeenBound

The member ProgramPipelineState::mHasBeenBound is unused and should be removed. Bug: angleproject:3570 Test: CQ Change-Id: Idc41574f79e665ac36bef5b206704c667c49dadb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301101Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>

Remove ProgramPipelineState::mHasBeenBound
e0a2bd5e · Tim Van Patten · Commit Bot · 22e1f3e2 · e0a2bd5e · e0a2bd5e
Commit e0a2bd5e authored Jul 15, 2020 by Tim Van Patten Committed by Commit Bot Jul 16, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 11 deletions

ProgramPipeline.cpp src/libANGLE/ProgramPipeline.cpp +1 -5

ProgramPipeline.h src/libANGLE/ProgramPipeline.h +0 -5

State.cpp src/libANGLE/State.cpp +0 -1

No files found.
--- a/src/libANGLE/ProgramPipeline.cpp
+++ b/src/libANGLE/ProgramPipeline.cpp
@@ -23,11 +23,7 @@ namespace gl
 {

 ProgramPipelineState::ProgramPipelineState()
-    : mLabel(),
-      mActiveShaderProgram(nullptr),
-      mValid(false),
-      mHasBeenBound(false),
-      mExecutable(new ProgramExecutable())
+    : mLabel(), mActiveShaderProgram(nullptr), mValid(false), mExecutable(new ProgramExecutable())
 {
    for (const ShaderType shaderType : gl::AllShaderTypes())
    {

--- a/src/libANGLE/ProgramPipeline.h
+++ b/src/libANGLE/ProgramPipeline.h
@@ -74,8 +74,6 @@ class ProgramPipelineState final : angle::NonCopyable

    GLboolean mValid;

-    GLboolean mHasBeenBound;
-
    ProgramExecutable *mExecutable;
 };

@@ -128,9 +126,6 @@ class ProgramPipeline final : public RefCountObject<ProgramPipelineID>, public L

    GLboolean isValid() const { return mState.isValid(); }

-    void bind() { mState.mHasBeenBound = true; }
-    GLboolean hasBeenBound() const { return mState.mHasBeenBound; }
-
    // Program pipeline dirty bits.
    enum DirtyBitType
    {

--- a/src/libANGLE/State.cpp
+++ b/src/libANGLE/State.cpp
@@ -1894,7 +1894,6 @@ angle::Result State::setProgramPipelineBinding(const Context *context, ProgramPi

    if (mProgramPipeline.get())
    {
-        mProgramPipeline->bind();
        ANGLE_TRY(onProgramPipelineExecutableChange(context, mProgramPipeline.get()));

        if (mProgramPipeline->hasAnyDirtyBit())