Skip to content

A
angle
Commit e1ccac7f by Yuly Novikov Committed by Commit Bot
Options

Don't print INFO level log messages in Release by default.

Even with dcheck_always_on. INFO level log messages will still be printed in Debug or when angle_enable_trace is enabled. Bug: angleproject:3525 Change-Id: Ic3807f94307af2878aee78426c969ab846ae3881 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050890Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
parent 3b82506a
Showing with 3 additions and 2 deletions
src/common/debug.cpp
...@@ -54,7 +54,7 @@ bool ShouldCreateLogMessage(LogSeverity severity) ...@@ -54,7 +54,7 @@ bool ShouldCreateLogMessage(LogSeverity severity)
#if defined(ANGLE_TRACE_ENABLED) #if defined(ANGLE_TRACE_ENABLED)
return true; return true;
#elif defined(ANGLE_ENABLE_ASSERTS) #elif defined(ANGLE_ENABLE_ASSERTS)
return severity != LOG_EVENT; return severity == LOG_FATAL || severity == LOG_ERR || severity == LOG_WARN;
#else #else
return false; return false;
#endif #endif
...@@ -254,7 +254,8 @@ void Trace(LogSeverity severity, const char *message) ...@@ -254,7 +254,8 @@ void Trace(LogSeverity severity, const char *message)
default: default:
UNREACHABLE(); UNREACHABLE();
} }
os_log_with_type(OS_LOG_DEFAULT, apple_log_type, "ANGLE: %s: %s\n", LogSeverityName(severity), str.c_str()); os_log_with_type(OS_LOG_DEFAULT, apple_log_type, "ANGLE: %s: %s\n",
LogSeverityName(severity), str.c_str());
} }
#else #else
// Note: we use fprintf because <iostream> includes static initializers. // Note: we use fprintf because <iostream> includes static initializers.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment