Skip to content

A
angle
Commit e4bd0418 by Kenneth Russell Committed by Geoff Lang
Options

Enable EXT_discard_framebuffer in ANGLE's D3D11 backend.

This doesn't seem to cause the video-related WebGL test failures anymore that were previously seen. BUG=497445 Change-Id: I705ae8735823ab7f4b26cf7696cdb746936e4447 Reviewed-on: https://chromium-review.googlesource.com/308001 Tryjob-Request: Kenneth Russell <kbr@chromium.org> Tested-by: 's avatarKenneth Russell <kbr@chromium.org> Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
parent 6ea6f942
Showing with 2 additions and 7 deletions
src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp
...@@ -1208,7 +1208,7 @@ void GenerateCaps(ID3D11Device *device, ID3D11DeviceContext *deviceContext, cons ...@@ -1208,7 +1208,7 @@ void GenerateCaps(ID3D11Device *device, ID3D11DeviceContext *deviceContext, cons
extensions->shaderTextureLOD = GetShaderTextureLODSupport(featureLevel); extensions->shaderTextureLOD = GetShaderTextureLODSupport(featureLevel);
extensions->fragDepth = true; extensions->fragDepth = true;
extensions->textureUsage = true; // This could be false since it has no effect in D3D11 extensions->textureUsage = true; // This could be false since it has no effect in D3D11
extensions->discardFramebuffer = false; // TODO: enable this once BUG:497445 is fixed (Chrome WebGL video tests fail with this extension active) extensions->discardFramebuffer = true;
extensions->translatedShaderSource = true; extensions->translatedShaderSource = true;
extensions->fboRenderMipmap = false; extensions->fboRenderMipmap = false;
extensions->debugMarker = true; extensions->debugMarker = true;
......
src/tests/gl_tests/DiscardFramebufferEXTTest.cpp
...@@ -30,12 +30,7 @@ TEST_P(DiscardFramebufferEXTTest, ExtensionEnabled) ...@@ -30,12 +30,7 @@ TEST_P(DiscardFramebufferEXTTest, ExtensionEnabled)
if (platform.renderer == EGL_PLATFORM_ANGLE_TYPE_D3D11_ANGLE) if (platform.renderer == EGL_PLATFORM_ANGLE_TYPE_D3D11_ANGLE)
{ {
// EXPECT_TRUE(extensionEnabled("EXT_discard_framebuffer")); EXPECT_TRUE(extensionEnabled("EXT_discard_framebuffer"));
// EXT_discard_framebuffer is disabled in D3D11 ANGLE due to Chromium BUG:497445
// Enabling this extension (even as a no-op) causes WebGL video failures in Chromium
// Once this bug is fixed, we can reenable the extension.
EXPECT_FALSE(extensionEnabled("EXT_discard_framebuffer"));
} }
else else
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment