Skip to content

A
angle
Commit e5009be8 by Ian Elliott Committed by Commit Bot
Options

Vulkan: Divide 3188 KHR failures into 2 known root causes + cleanup.

The two root causes are angleproject:3695 and angleproject:3836. Some tests failing from angleproject:3836 were still labeled for angleproject:3458. This CL does some cleanup of that, and improves the comments for the two root-causes. Bug: angleproject:3188 Bug: angleproject:3458 Bug: angleproject:3695 Bug: angleproject:3836 Change-Id: I4c9be0b3078c1fc21064fb88b58e28ea92c3a73c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1834275Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
parent 8c3bb48f
Showing with 45 additions and 12 deletions
src/tests/deqp_support/deqp_khr_gles3_test_expectations.txt
...@@ -31,23 +31,16 @@ ...@@ -31,23 +31,16 @@
// For now we only log Vulkan test expectations. More back-ends can follow as we need them. // For now we only log Vulkan test expectations. More back-ends can follow as we need them.
// GL_RGB32F framebuffers should not be "complete" (may crash on Android, but only fails elsewhere): // Need to publish the "GL_CHROMIUM_color_buffer_float_rgb" extension, and then modify the dEQP
// KHR test source code to consider GL_RGB32F as renderable:
3695 VULKAN : KHR-GLES3.packed_pixels.rectangle.rgb*32f = FAIL 3695 VULKAN : KHR-GLES3.packed_pixels.rectangle.rgb*32f = FAIL
3695 VULKAN : KHR-GLES3.packed_pixels.pbo_rectangle.rgb*32f = FAIL 3695 VULKAN : KHR-GLES3.packed_pixels.pbo_rectangle.rgb*32f = FAIL
3695 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgb*32f = FAIL
// Depth/stencil related failures. // Depth/stencil related failures.
3683 VULKAN ANDROID : KHR-GLES3.packed_depth_stencil.*.depth24_stencil8 = FAIL 3683 VULKAN ANDROID : KHR-GLES3.packed_depth_stencil.*.depth24_stencil8 = FAIL
3683 VULKAN ANDROID : KHR-GLES3.packed_depth_stencil.*.depth32f_stencil8 = FAIL 3683 VULKAN ANDROID : KHR-GLES3.packed_depth_stencil.*.depth32f_stencil8 = FAIL
// CopyTexImage conversion actually failing the test code.
3458 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_texture2d = FAIL
3458 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_negx = FAIL
3458 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_negy = FAIL
3458 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_negz = FAIL
3458 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_posx = FAIL
3458 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_posy = FAIL
3458 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_posz = FAIL
// CopyTexImage conversion failing due to Vulkan validation error re: UINT/SINT-descriptor-set issue. // CopyTexImage conversion failing due to Vulkan validation error re: UINT/SINT-descriptor-set issue.
3817 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture_array_texture2d = FAIL 3817 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture_array_texture2d = FAIL
3817 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture_array_cubemap_negx = FAIL 3817 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture_array_cubemap_negx = FAIL
...@@ -115,5 +108,45 @@ ...@@ -115,5 +108,45 @@
3818 VULKAN : KHR-GLES3.copy_tex_image_conversions.forbidden.renderbuffer_cubemap_posy = FAIL 3818 VULKAN : KHR-GLES3.copy_tex_image_conversions.forbidden.renderbuffer_cubemap_posy = FAIL
3818 VULKAN : KHR-GLES3.copy_tex_image_conversions.forbidden.renderbuffer_cubemap_posz = FAIL 3818 VULKAN : KHR-GLES3.copy_tex_image_conversions.forbidden.renderbuffer_cubemap_posz = FAIL
// Require 3D textures. // glCopyTexImage from 3D textures is failing and getting the following Vulkan Validation errors:
3188 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.* = SKIP //
// ImageView must not be a 2D or 2DArray view of a 3D image. The Vulkan spec states:
// imageView must not be 2D or 2D array image view created from a 3D image
//
3836 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_texture2d = FAIL
3836 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_negx = FAIL
3836 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_negy = FAIL
3836 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_negz = FAIL
3836 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_posx = FAIL
3836 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_posy = FAIL
3836 VULKAN : KHR-GLES3.copy_tex_image_conversions.required.texture3d_cubemap_posz = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.r8 = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rg8 = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rg8i = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rg8ui = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgb8 = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgba8 = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgba8i = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgba8ui = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rg16i = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rg16ui = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rg16f = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgb16f = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgba16i = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgba16ui = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgba16f = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rg32i = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rg32ui = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rg32f = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgba32i = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgba32ui = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgb = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgb565 = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgb5_a1 = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.srgb8_alpha8 = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgba = FAIL
3836 VULKAN : KHR-GLES3.packed_pixels.varied_rectangle.rgba4 = FAIL
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment