Vulkan: Expose OES_shader_image_atomic without VS/FS atomics

If vertexPipelineStoresAndAtomics is not available, the vertex stage limit for images is set to 0, so there won't be any images in that stage. Similarly for fragmentStoresAndAtomics. The extension can still be exposed for use with compute shaders. Bug: angleproject:3578 Change-Id: I86133415bc14c219067827758e727ce7ab079973 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2536252Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Vulkan: Expose OES_shader_image_atomic without VS/FS atomics
e5a5567d · Shahbaz Youssefi · Commit Bot · 84fce18c · e5a5567d
Commit e5a5567d authored Nov 12, 2020 by Shahbaz Youssefi Committed by Commit Bot Nov 16, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

vk_caps_utils.cpp src/libANGLE/renderer/vulkan/vk_caps_utils.cpp +5 -3

No files found.
--- a/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
+++ b/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
@@ -373,10 +373,12 @@ void RendererVk::ensureCapsInitialized() const
    // OES_shader_multisample_interpolation requires OES_sample_variables, disable for now
    mNativeExtensions.multisampleInterpolationOES = false;

+    // Atomic image operations in the vertex and fragment shaders require the
+    // vertexPipelineStoresAndAtomics and fragmentStoresAndAtomics Vulkan features respectively.
+    // If either of these features is not present, the number of image uniforms for that stage is
+    // advertized as zero, so image atomic operations support can be agnostic of shader stages.
    mNativeExtensions.shaderImageAtomicOES =
-        ((mPhysicalDeviceFeatures.vertexPipelineStoresAndAtomics == VK_TRUE) &&
-         (mPhysicalDeviceFeatures.fragmentStoresAndAtomics == VK_TRUE) &&
-         getFeatures().supportsShaderImageFloat32Atomics.enabled);
+        getFeatures().supportsShaderImageFloat32Atomics.enabled;

    // https://vulkan.lunarg.com/doc/view/1.0.30.0/linux/vkspec.chunked/ch31s02.html
    mNativeCaps.maxElementIndex  = std::numeric_limits<GLuint>::max() - 1;