Commit e8d71eb3 by Michael Spang Committed by Commit Bot

Vulkan: Fix ANGLE_ENABLE_VULKAN_VALIDATION_LAYERS_BY_DEFAULT

Unfortunately this was broken by 605af42e ("Vulkan: Move ICD overrides to a common place"). This adds an unconditional dependency on the layers to tests. Tests don't respect angle_enable_vulkan_validation_layers, so we need to ship the layers irrespective of that setting. Bug: angleproject:4634 Change-Id: Ided291ea645a72e6c3bdb960e55d15013aa20a3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2197279Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 4b225c70
...@@ -35,18 +35,6 @@ angle_source_set("vulkan") { ...@@ -35,18 +35,6 @@ angle_source_set("vulkan") {
data_deps += [ "$angle_root/third_party/vulkan-tools/src:VkICD_mock_icd" ] data_deps += [ "$angle_root/third_party/vulkan-tools/src:VkICD_mock_icd" ]
} }
if (angle_enable_vulkan_validation_layers) {
defines += [ "ANGLE_ENABLE_VULKAN_VALIDATION_LAYERS_BY_DEFAULT" ]
if (is_fuchsia) {
data_deps += [ "//third_party/fuchsia-sdk:vulkan_validation" ]
} else {
data_deps += [ "$angle_root/third_party/vulkan-validation-layers/src:vulkan_validation_layers" ]
if (!is_android) {
data_deps += [ "$angle_root/third_party/vulkan-validation-layers/src:vulkan_gen_json_files" ]
}
}
}
if (angle_enable_swiftshader) { if (angle_enable_swiftshader) {
import("$swiftshader_dir/src/Vulkan/vulkan.gni") import("$swiftshader_dir/src/Vulkan/vulkan.gni")
_sws_icd = "./$swiftshader_icd_file_name" _sws_icd = "./$swiftshader_icd_file_name"
...@@ -62,3 +50,15 @@ angle_source_set("vulkan") { ...@@ -62,3 +50,15 @@ angle_source_set("vulkan") {
] ]
} }
} }
group("vulkan_validation_layers") {
data_deps = []
if (is_fuchsia) {
data_deps += [ "//third_party/fuchsia-sdk:vulkan_validation" ]
} else {
data_deps += [ "$angle_root/third_party/vulkan-validation-layers/src:vulkan_validation_layers" ]
if (!is_android) {
data_deps += [ "$angle_root/third_party/vulkan-validation-layers/src:vulkan_gen_json_files" ]
}
}
}
...@@ -247,6 +247,13 @@ angle_source_set("angle_vulkan_backend") { ...@@ -247,6 +247,13 @@ angle_source_set("angle_vulkan_backend") {
data_deps = [] data_deps = []
defines = []
if (angle_enable_vulkan_validation_layers) {
defines += [ "ANGLE_ENABLE_VULKAN_VALIDATION_LAYERS_BY_DEFAULT" ]
data_deps += [ "$angle_root/src/common/vulkan:vulkan_validation_layers" ]
}
if (is_android) { if (is_android) {
libs += [ "vulkan" ] libs += [ "vulkan" ]
} }
......
...@@ -93,6 +93,10 @@ template("angle_common_test_utils") { ...@@ -93,6 +93,10 @@ template("angle_common_test_utils") {
"test_utils/angle_test_instantiate_apple.mm", "test_utils/angle_test_instantiate_apple.mm",
] ]
} }
data_deps = []
if (angle_enable_vulkan) {
data_deps += [ "$angle_root/src/common/vulkan:vulkan_validation_layers" ]
}
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment