Commit e9813ba0 by Jamie Madill Committed by Commit Bot

trigger.py: Add launching of Android tests.

This adds new conditonal arguments --device-type and --device-os (shortened as -t and -o) that specify an Android device type/OS. In practice only -t is usually necessary. Also makes the GPU dimension optional (-g or --gpu). Bug: angleproject:5109 Bug: chromium:1133459 Change-Id: Id975c676db40e9eb104b73a4ed5858e6083cbd70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2439481Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com> Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent f57b00f1
...@@ -19,9 +19,12 @@ def parse_args(): ...@@ -19,9 +19,12 @@ def parse_args():
parser.add_argument('gn_path', help='path to GN. (e.g. out/Release)') parser.add_argument('gn_path', help='path to GN. (e.g. out/Release)')
parser.add_argument('test', help='test name. (e.g. angle_end2end_tests)') parser.add_argument('test', help='test name. (e.g. angle_end2end_tests)')
parser.add_argument('os_dim', help='OS dimension. (e.g. Windows-10)') parser.add_argument('os_dim', help='OS dimension. (e.g. Windows-10)')
parser.add_argument('gpu_dim', help='GPU dimension. (e.g. intel-hd-630-win10-stable)')
parser.add_argument('-s', '--shards', default=1, help='number of shards', type=int) parser.add_argument('-s', '--shards', default=1, help='number of shards', type=int)
parser.add_argument('-p', '--pool', default='Chrome-GPU', help='swarming pool') parser.add_argument('-p', '--pool', default='Chrome-GPU', help='swarming pool')
parser.add_argument('-g', '--gpu', help='GPU dimension. (e.g. intel-hd-630-win10-stable)')
parser.add_argument('-t', '--device-type', help='Android device type (e.g. bullhead)')
parser.add_argument('-o', '--device-os', help='Android OS.')
return parser.parse_known_args() return parser.parse_known_args()
...@@ -52,9 +55,18 @@ def main(): ...@@ -52,9 +55,18 @@ def main():
swarming_args = [ swarming_args = [
swarming_script_path, 'trigger', '-S', 'chromium-swarm.appspot.com', '-I', swarming_script_path, 'trigger', '-S', 'chromium-swarm.appspot.com', '-I',
'https://isolateserver.appspot.com', '-d', 'os=' + args.os_dim, '-d', 'pool=' + args.pool, 'https://isolateserver.appspot.com', '-d', 'os=' + args.os_dim, '-d', 'pool=' + args.pool,
'-d', 'gpu=' + args.gpu_dim, '-s', sha '-s', sha
] ]
if args.gpu:
swarming_args += ['-d', 'gpu=' + args.gpu]
if args.device_type:
swarming_args += ['-d', 'device_type=' + args.device_type]
if args.device_os:
swarming_args += ['-d', 'device_os=' + args.device_os]
for i in range(args.shards): for i in range(args.shards):
shard_args = swarming_args[:] shard_args = swarming_args[:]
shard_args.extend([ shard_args.extend([
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment