Commit e9cffa62 by Li, Hao Committed by Commit Bot

Rename data_dir to angle_data_dir in GN files

Dawn reuses the Vulkan validation layers of ANGLE to avoid building twice in chromium, and references build_overrides/vulkan_common.gni, but angle_data_dir is undefined, which is defined as data_dir in angle.gni. There is a reminder to rename this name in https://chromium-review.googlesource.com/c/chromium/src/+/1610488 Bug: angleproject:3710 Change-Id: I4b7c4d24c37770ff58b70c988851a6ed32a04296 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1703175Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
parent c44d2c79
...@@ -21,7 +21,7 @@ if (build_with_chromium) { ...@@ -21,7 +21,7 @@ if (build_with_chromium) {
} }
# Subdirectory to place data files (e.g. layer JSON files). # Subdirectory to place data files (e.g. layer JSON files).
data_dir = "angledata" angle_data_dir = "angledata"
declare_args() { declare_args() {
if (current_cpu == "arm64" || current_cpu == "x64" || if (current_cpu == "arm64" || current_cpu == "x64" ||
......
...@@ -1007,7 +1007,7 @@ if (build_angle_deqp_tests && !is_fuchsia) { ...@@ -1007,7 +1007,7 @@ if (build_angle_deqp_tests && !is_fuchsia) {
] ]
outputs = [ outputs = [
"$root_out_dir/$data_dir/gl_cts/data/gles3/{{source_file_part}}", "$root_out_dir/$angle_data_dir/gl_cts/data/gles3/{{source_file_part}}",
] ]
} }
...@@ -1019,12 +1019,12 @@ if (build_angle_deqp_tests && !is_fuchsia) { ...@@ -1019,12 +1019,12 @@ if (build_angle_deqp_tests && !is_fuchsia) {
":angle_deqp_khr_data", ":angle_deqp_khr_data",
] ]
defines += [ "ANGLE_DEQP_DATA_DIR=\"$data_dir\"" ] defines += [ "ANGLE_DEQP_DATA_DIR=\"$angle_data_dir\"" ]
mustpass_dir = _khronos_mustpass mustpass_dir = _khronos_mustpass
data = [ data = [
"$root_out_dir/$data_dir/gl_cts/", "$root_out_dir/$angle_data_dir/gl_cts/",
] ]
} }
} }
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
# https://github.com/KhronosGroup/Vulkan-Loader # https://github.com/KhronosGroup/Vulkan-Loader
import("../../gni/angle.gni") import("../../gni/angle.gni")
import("$angle_root/third_party/vulkan-headers/vulkan_headers_script_deps.gni") import("$angle_root/third_party/vulkan-headers/vulkan_headers_script_deps.gni")
# Fuchsia has non-upstream changes to the vulkan loader, so we don't want # Fuchsia has non-upstream changes to the vulkan loader, so we don't want
...@@ -166,8 +167,8 @@ config("vulkan_loader_config") { ...@@ -166,8 +167,8 @@ config("vulkan_loader_config") {
"src/loader", "src/loader",
] ]
defines = [ defines = [
"ANGLE_VK_DATA_DIR=\"$data_dir\"", "ANGLE_VK_DATA_DIR=\"$angle_data_dir\"",
"ANGLE_VK_ICD_JSON=\"$data_dir/VkICD_mock_icd.json\"", "ANGLE_VK_ICD_JSON=\"$angle_data_dir/VkICD_mock_icd.json\"",
"API_NAME=\"Vulkan\"", "API_NAME=\"Vulkan\"",
] ]
......
...@@ -183,10 +183,10 @@ if (!is_android) { ...@@ -183,10 +183,10 @@ if (!is_android) {
# The layer JSON files are part of the necessary data deps. # The layer JSON files are part of the necessary data deps.
outputs = [ outputs = [
"$root_out_dir/$data_dir/VkICD_mock_icd.json", "$root_out_dir/$angle_data_dir/VkICD_mock_icd.json",
] ]
data = outputs data = outputs
args += [ rebase_path("$root_out_dir/$data_dir", root_build_dir) ] + args += [ rebase_path("$root_out_dir/$angle_data_dir", root_build_dir) ] +
rebase_path(sources, root_build_dir) rebase_path(sources, root_build_dir)
} }
} }
...@@ -23,7 +23,7 @@ if (is_win) { ...@@ -23,7 +23,7 @@ if (is_win) {
} }
raw_root_out_dir = rebase_path(root_out_dir, root_build_dir) raw_root_out_dir = rebase_path(root_out_dir, root_build_dir)
raw_data_dir = rebase_path("$root_out_dir/$data_dir", root_build_dir) raw_data_dir = rebase_path("$root_out_dir/$angle_data_dir", root_build_dir)
raw_vulkan_headers_dir = raw_vulkan_headers_dir =
rebase_path("$angle_root/third_party/vulkan-headers/src", root_build_dir) rebase_path("$angle_root/third_party/vulkan-headers/src", root_build_dir)
...@@ -419,11 +419,11 @@ if (!is_android) { ...@@ -419,11 +419,11 @@ if (!is_android) {
outputs = [] outputs = []
foreach(json_name, json_names) { foreach(json_name, json_names) {
sources += [ "src/layers/json/$json_name.in" ] sources += [ "src/layers/json/$json_name.in" ]
outputs += [ "$root_out_dir/$data_dir/$json_name" ] outputs += [ "$root_out_dir/$angle_data_dir/$json_name" ]
} }
args = [ args = [
"$raw_vulkan_layers_dir/layers/json", "$raw_vulkan_layers_dir/layers/json",
rebase_path("$root_out_dir/$data_dir", root_build_dir), rebase_path("$root_out_dir/$angle_data_dir", root_build_dir),
] + rebase_path(sources, root_build_dir) ] + rebase_path(sources, root_build_dir)
# The layer JSON files are part of the necessary data deps. # The layer JSON files are part of the necessary data deps.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment