Skip to content

A
angle
Commit e9d7f2d1 by Jiawei Shao Committed by Commit Bot
Options

ES31: Skip dEQP tests geometry_shading.vertex_transform_feedback.*

This patch labels geometry_shading.vertex_transform_feedback.* as "SKIP" instead of "FAIL" to fix some failures in dEQP tests. OpenGL ES 3.1 extension GL_EXT_geometry_shader requires additional validations on transform feedback, which hasn't been implemented in ANGLE, so geometry_shading.vertex_transform_feedback.* fail just after beginTransformfeedback(). As endTransformfeedback() isn't called in dEQP function resetStateES(): 1. An error occurs in this function when trying to clear transform feedback. 2. Some of the tests afterwards also fail because it isn't allowed to change active program by useProgram() when transform feedback is on. So it is better to skip these tests before ANGLE supports these new features. BUG=angleproject:1941 Change-Id: I8834f71e6a655f18118ee4ecf26f4118da6de2f1 Reviewed-on: https://chromium-review.googlesource.com/843955 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: 's avatarJiajia Qin <jiajia.qin@intel.com> Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
parent f3e23295
Showing with 2 additions and 1 deletion
src/tests/deqp_support/deqp_gles31_test_expectations.txt
......@@ -42,6 +42,8 @@
1941 OPENGL D3D11 : dEQP-GLES31.functional.geometry_shading.layered.* = SKIP
1941 OPENGL D3D11 : dEQP-GLES31.functional.geometry_shading.instanced.invocation_per_layer_* = SKIP
1941 OPENGL D3D11 : dEQP-GLES31.functional.geometry_shading.instanced.multiple_layers_per_invocation_* = SKIP
// TODO(jiawei.shao@intel.com): Implement validations on transform feedback required in OpenGL ES 3.1 extension GL_EXT_geometry_shader
1941 OPENGL D3D11 : dEQP-GLES31.functional.geometry_shading.vertex_transform_feedback.* = SKIP
// D3D11 Failing Tests
1442 D3D11 : dEQP-GLES31.functional.state_query.integer.max_compute_shared_memory_size_* = FAIL
......@@ -1677,5 +1679,4 @@
1941 OPENGL D3D11 : dEQP-GLES31.functional.geometry_shading.instanced.geometry_* = FAIL
1941 OPENGL D3D11 : dEQP-GLES31.functional.geometry_shading.instanced.invocation_output_* = FAIL
1941 OPENGL D3D11 : dEQP-GLES31.functional.geometry_shading.instanced.draw_* = FAIL
1941 OPENGL D3D11 : dEQP-GLES31.functional.geometry_shading.vertex_transform_feedback.* = FAIL
1941 OPENGL D3D11 : dEQP-GLES31.functional.geometry_shading.negative.* = FAIL
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment