Add scrict type checking for reinterpret_cast

Bug: angleproject:5891 Change-Id: I4077fea7fde91465fa71df843c313c4dd8e31e0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846835Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>

Add scrict type checking for reinterpret_cast
ea76c5ad · John Plate · Commit Bot · 7a161a56 · ea76c5ad
Commit ea76c5ad authored Apr 23, 2021 by John Plate Committed by Commit Bot Apr 23, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

PackedEnums.h src/common/PackedEnums.h +8 -0

No files found.
--- a/src/common/PackedEnums.h
+++ b/src/common/PackedEnums.h
@@ -761,6 +761,14 @@ template <typename EnumT, typename FromT>
 typename std::enable_if<std::is_pointer<FromT>::value && !std::is_enum<EnumT>::value, EnumT>::type
 PackParam(FromT from)
 {
+    static_assert(sizeof(typename std::remove_pointer<EnumT>::type) ==
+                      sizeof(typename std::remove_pointer<FromT>::type),
+                  "Types have different sizes");
+    static_assert(
+        std::is_same<
+            decltype(std::remove_pointer<EnumT>::type::value),
+            typename std::remove_const<typename std::remove_pointer<FromT>::type>::type>::value,
+        "Data types are different");
    return reinterpret_cast<EnumT>(from);
 }