Skip to content

A
angle
Commit eaa6961d by Shahbaz Youssefi Committed by Commit Bot
Options

Revert "Vulkan: Disable BufferVk suballocation"

This reverts commit 76181384. Reason for revert: Bug exposed by this is fixed in https://chromium-review.googlesource.com/c/angle/angle/+/2896168 Original change's description: > Vulkan: Disable BufferVk suballocation > > There are still unresolved bugs. > > Bug: angleproject:5719 > Bug: chromium:1209197 > Change-Id: I6a971c421d0ae266404d1ecbf8741a9747a4e809 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2897545 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Tim Van Patten <timvp@google.com> Bug: angleproject:5719 Bug: chromium:1209197 Change-Id: I5c24b5f6476eab98ed5a7b90b3d1796ffc7ca106 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2896169 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 421c665c
Showing with 7 additions and 11 deletions
src/libANGLE/renderer/vulkan/BufferVk.cpp
...@@ -130,19 +130,15 @@ size_t GetPreferredDynamicBufferInitialSize(RendererVk *renderer, ...@@ -130,19 +130,15 @@ size_t GetPreferredDynamicBufferInitialSize(RendererVk *renderer,
// DynamicBuffer allocate bigger blocks to suballocate from. Otherwise, let it adapt to the // DynamicBuffer allocate bigger blocks to suballocate from. Otherwise, let it adapt to the
// buffer size automatically (which will allocate BufferHelpers with the same size as this // buffer size automatically (which will allocate BufferHelpers with the same size as this
// buffer). // buffer).
// const bool isDynamic = usage == gl::BufferUsage::DynamicDraw ||
// TODO: fix bugs with suballocation and uncomment the following. http://anglebug.com/5719 usage == gl::BufferUsage::DynamicCopy ||
// const bool isDynamic = usage == gl::BufferUsage::DynamicDraw || usage == gl::BufferUsage::DynamicRead;
// usage == gl::BufferUsage::DynamicCopy ||
// usage == gl::BufferUsage::DynamicRead;
// Sub-allocate from a 4KB buffer. If the buffer allocations are bigger, the dynamic buffer // Sub-allocate from a 4KB buffer. If the buffer allocations are bigger, the dynamic buffer
// will adapt to it automatically (and stop sub-allocating). // will adapt to it automatically (and stop sub-allocating).
// constexpr size_t kDynamicBufferMaxSize = 4 * 1024;
// constexpr size_t kDynamicBufferMaxSize = 4 * 1024; const size_t alignedSize = roundUp(dataSize, *alignmentOut);
// const size_t alignedSize = roundUp(dataSize, *alignmentOut); const size_t suballocationCount = kDynamicBufferMaxSize / alignedSize;
// const size_t suballocationCount = kDynamicBufferMaxSize / alignedSize; const size_t initialSize = isDynamic ? alignedSize * suballocationCount : 0;
// const size_t initialSize = isDynamic ? alignedSize * suballocationCount : 0;
const size_t initialSize = 0;
return initialSize; return initialSize;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment