Roll GYP for VS2017 project support.

DEPS

@@ -25,7 +25,7 @@ deps = {
     Var('android_git') + '/platform/external/shaderc/glslang' + '@' + '1e275c8486325aaab34734ad9a650c0121c5efdb',
 
   'third_party/gyp':
-    Var('chromium_git') + '/external/gyp' + '@' + 'aae1e3efb50786df20e9572621fb746865f0df53',
+    Var('chromium_git') + '/external/gyp' + '@' + 'c6f471687407bf28ddfc63f1a8f47aeb7bf54edc',
 
   'third_party/libpng':
     Var('android_git') + '/platform/external/libpng' + '@' + '094e181e79a3d6c23fd005679025058b7df1ad6c',

src/common/string_utils.cpp

@@ -179,4 +179,12 @@ bool EndsWith(const std::string &str, const char *suffix)
     return memcmp(end, suffix, len) == 0;
 }
 
+void ToLower(std::string *str)
+{
+    for (auto &ch : *str)
+    {
+        ch = static_cast<char>(::tolower(ch));
+    }
+}
+
 }  // namespace angle

src/common/string_utils.h

@@ -62,6 +62,9 @@ bool BeginsWith(const char *str, const char *prefix);
 // Suffix may not be NUL and needs to be NULL terminated.
 // The comparison is case sensitive.
 bool EndsWith(const std::string& str, const char* suffix);
+
+// Convert to lower-case.
+void ToLower(std::string *str);
 }
 
 #endif // LIBANGLE_STRING_UTILS_H_

src/tests/gl_tests/ProgramBinaryTest.cpp

@@ -11,6 +11,7 @@
 
 #include "EGLWindow.h"
 #include "OSWindow.h"
+#include "common/string_utils.h"
 #include "test_utils/angle_test_configs.h"
 #include "test_utils/gl_raii.h"
 
@@ -761,7 +762,7 @@ TEST_P(ProgramBinariesAcrossPlatforms, CreateAndReloadBinary)
         secondRenderer.eglParameters.deviceType == EGL_PLATFORM_ANGLE_DEVICE_TYPE_WARP_ANGLE)
     {
         std::string rendererString = std::string(reinterpret_cast<const char*>(glGetString(GL_RENDERER)));
-        std::transform(rendererString.begin(), rendererString.end(), rendererString.begin(), ::tolower);
+        angle::ToLower(&rendererString);
 
         auto basicRenderPos = rendererString.find(std::string("microsoft basic render"));
         auto softwareAdapterPos = rendererString.find(std::string("software adapter"));

src/tests/gl_tests/RendererTest.cpp

@@ -10,6 +10,8 @@
 
 #include "test_utils/ANGLETest.h"
 
+#include "common/string_utils.h"
+
 using namespace angle;
 
 namespace
@@ -28,10 +30,10 @@ class RendererTest : public ANGLETest
 TEST_P(RendererTest, RequestedRendererCreated)
 {
     std::string rendererString = std::string(reinterpret_cast<const char*>(glGetString(GL_RENDERER)));
-    std::transform(rendererString.begin(), rendererString.end(), rendererString.begin(), ::tolower);
+    angle::ToLower(&rendererString);
 
     std::string versionString = std::string(reinterpret_cast<const char*>(glGetString(GL_VERSION)));
-    std::transform(versionString.begin(), versionString.end(), versionString.begin(), ::tolower);
+    angle::ToLower(&versionString);
 
     const EGLPlatformParameters &platform = GetParam().eglParameters;
 

src/vulkan_support/vulkan.gypi

@@ -355,6 +355,7 @@
                             'AdditionalOptions':
                             [
                                 '/wd4100', # Unreferenced formal parameter
+                                '/wd4244', # Conversion from 'int' to 'char', possible loss of data
                                 '/wd4456', # Declaration hides previous local declaration
                                 '/wd4457', # Declaration hides function parameter
                                 '/wd4458', # Declaration hides class member