Expand clear tests for more mask combinations

The test was previously either masking every three aspect (color, depth and stencil) or none. This was not exercising every clear path in the Vulkan backend. Bug: angleproject:3241 Change-Id: Ief4085ea302ec17bffe30b1f8510ae357fd01290 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1551523 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Expand clear tests for more mask combinations
efec568b · Shahbaz Youssefi · Commit Bot · c7565353 · efec568b · efec568b
Commit efec568b authored Apr 03, 2019 by Shahbaz Youssefi Committed by Commit Bot Apr 06, 2019
Expand all Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 0 deletions

ClearTest.cpp src/tests/gl_tests/ClearTest.cpp +0 -0

angle_test_instantiate.h src/tests/test_utils/angle_test_instantiate.h +7 -0

No files found.
--- a/src/tests/gl_tests/ClearTest.cpp
+++ b/src/tests/gl_tests/ClearTest.cpp
--- a/src/tests/test_utils/angle_test_instantiate.h
+++ b/src/tests/test_utils/angle_test_instantiate.h
@@ -98,6 +98,13 @@ struct CombinedPrintToStringParamName
    const decltype(first) testName##params[] = {first, ##__VA_ARGS__};          \
    INSTANTIATE_TEST_SUITE_P(                                                   \
        , testName, testing::Combine(ANGLE_INSTANTIATE_TEST_PLATFORMS(testName), combine1), print)
+#define ANGLE_INSTANTIATE_TEST_COMBINE_4(testName, print, combine1, combine2, combine3, combine4, \
+                                         first, ...)                                              \
+    const decltype(first) testName##params[] = {first, ##__VA_ARGS__};                            \
+    INSTANTIATE_TEST_SUITE_P(, testName,                                                          \
+                             testing::Combine(ANGLE_INSTANTIATE_TEST_PLATFORMS(testName),         \
+                                              combine1, combine2, combine3, combine4),            \
+                             print)
 #define ANGLE_INSTANTIATE_TEST_COMBINE_5(testName, print, combine1, combine2, combine3, combine4, \
                                         combine5, first, ...)                                    \
    const decltype(first) testName##params[] = {first, ##__VA_ARGS__};                            \