Allow enabling trace annotations

Tracing was never allowed to happen because getStatus always returned false. Also want to allow tracing for release builds for perf analysis. Bug: angleproject:3176 Change-Id: I7aa94ed9fe3d7f67fe6dd10123c9badc7fb49d82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1475248 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@google.com>

Allow enabling trace annotations
f094bac9 · Courtney Goeltzenleuchter · Commit Bot · 2f1c1d7e · f094bac9 · f094bac9
Commit f094bac9 authored Feb 15, 2019 by Courtney Goeltzenleuchter Committed by Commit Bot Mar 05, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

BUILD.gn BUILD.gn +1 -1

LoggingAnnotator.cpp src/libANGLE/LoggingAnnotator.cpp +4 -0

No files found.
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -200,7 +200,7 @@ config("angle_disable_pool_alloc") {
 }
 config("debug_annotations_config") {
-  if (is_debug) {
+  if (is_debug || angle_enable_trace) {
    defines = [ "ANGLE_ENABLE_DEBUG_ANNOTATIONS" ]
  }
 }

--- a/src/libANGLE/LoggingAnnotator.cpp
+++ b/src/libANGLE/LoggingAnnotator.cpp
@@ -16,7 +16,11 @@ namespace angle
 bool LoggingAnnotator::getStatus()
 {
+#if defined(ANGLE_TRACE_ENABLED)
+    return true;
+#else
    return false;
+#endif
 }
 void LoggingAnnotator::beginEvent(const char *eventName, const char *eventMessage)