Commit f786b706 by Luc Ferron Committed by Commit Bot

Vulkan: Enable viewport Y flipping

Bug: angleproject:2728 Bug: angleproject:2726 Bug: angleproject:2673 Bug: angleproject:2729 Change-Id: Iad657a116bf9fcd06c3d4cf1918aaacba4f1fd38 Reviewed-on: https://chromium-review.googlesource.com/1131515Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Luc Ferron <lucferron@chromium.org>
parent 21061026
...@@ -653,10 +653,9 @@ void RendererVk::initFeatures() ...@@ -653,10 +653,9 @@ void RendererVk::initFeatures()
// Use OpenGL line rasterization rules by default. // Use OpenGL line rasterization rules by default.
mFeatures.basicGLLineRasterization = true; mFeatures.basicGLLineRasterization = true;
// For now, set this manually to true to enable viewport flipping. A couple of features are not // TODO(lucferron): Currently disabled on Intel only since many tests are failing and need
// working well like copyTexImage, copySubTexImage, blit, and probably some more. Until // investigation. http://anglebug.com/2728
// everything is fixed, we will keep the viewport flipping feature disabled. mFeatures.flipViewportY = !IsIntel(mPhysicalDeviceProperties.vendorID);
mFeatures.flipViewportY = false;
} }
void RendererVk::ensureCapsInitialized() const void RendererVk::ensureCapsInitialized() const
......
...@@ -574,6 +574,9 @@ TEST_P(BlitFramebufferANGLETest, ReverseOversizedBlit) ...@@ -574,6 +574,9 @@ TEST_P(BlitFramebufferANGLETest, ReverseOversizedBlit)
// blit from user-created FBO to system framebuffer, with depth buffer. // blit from user-created FBO to system framebuffer, with depth buffer.
TEST_P(BlitFramebufferANGLETest, BlitWithDepthUserToDefault) TEST_P(BlitFramebufferANGLETest, BlitWithDepthUserToDefault)
{ {
// TODO(lucferron): Diagnose and fix http://anglebug.com/2729
ANGLE_SKIP_TEST_IF(IsAMD() && IsVulkan());
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_ANGLE_framebuffer_blit")); ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_ANGLE_framebuffer_blit"));
glBindFramebuffer(GL_FRAMEBUFFER, mUserFBO); glBindFramebuffer(GL_FRAMEBUFFER, mUserFBO);
...@@ -627,6 +630,9 @@ TEST_P(BlitFramebufferANGLETest, BlitWithDepthUserToDefault) ...@@ -627,6 +630,9 @@ TEST_P(BlitFramebufferANGLETest, BlitWithDepthUserToDefault)
// blit from system FBO to user-created framebuffer, with depth buffer. // blit from system FBO to user-created framebuffer, with depth buffer.
TEST_P(BlitFramebufferANGLETest, BlitWithDepthDefaultToUser) TEST_P(BlitFramebufferANGLETest, BlitWithDepthDefaultToUser)
{ {
// TODO(lucferron): Diagnose and fix http://anglebug.com/2729
ANGLE_SKIP_TEST_IF(IsAMD() && IsVulkan());
ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_ANGLE_framebuffer_blit")); ANGLE_SKIP_TEST_IF(!extensionEnabled("GL_ANGLE_framebuffer_blit"));
glBindFramebuffer(GL_FRAMEBUFFER, mOriginalFBO); glBindFramebuffer(GL_FRAMEBUFFER, mOriginalFBO);
...@@ -821,6 +827,9 @@ TEST_P(BlitFramebufferANGLETest, BlitStencil) ...@@ -821,6 +827,9 @@ TEST_P(BlitFramebufferANGLETest, BlitStencil)
// TODO(lucferron): Diagnose and fix http://anglebug.com/2693 // TODO(lucferron): Diagnose and fix http://anglebug.com/2693
ANGLE_SKIP_TEST_IF(IsIntel() && IsLinux() && IsVulkan()); ANGLE_SKIP_TEST_IF(IsIntel() && IsLinux() && IsVulkan());
// TODO(lucferron): Diagnose and fix http://anglebug.com/2729
ANGLE_SKIP_TEST_IF(IsAMD() && IsVulkan());
glBindFramebuffer(GL_FRAMEBUFFER, mUserFBO); glBindFramebuffer(GL_FRAMEBUFFER, mUserFBO);
glClearColor(0.0, 1.0, 0.0, 1.0); glClearColor(0.0, 1.0, 0.0, 1.0);
......
...@@ -1557,6 +1557,10 @@ TEST_P(Texture2DTest, CopySubImageFloat_RGBA_RGB) ...@@ -1557,6 +1557,10 @@ TEST_P(Texture2DTest, CopySubImageFloat_RGBA_RGB)
TEST_P(Texture2DTest, CopySubImageFloat_RGBA_RGBA) TEST_P(Texture2DTest, CopySubImageFloat_RGBA_RGBA)
{ {
// TODO(lucferron): This test fails only on linux and intel.
// http://anglebug.com/2726
ANGLE_SKIP_TEST_IF(IsVulkan() && IsLinux() && IsIntel());
// Ignore SDK layers messages on D3D11 FL 9.3 (http://anglebug.com/1284) // Ignore SDK layers messages on D3D11 FL 9.3 (http://anglebug.com/1284)
ANGLE_SKIP_TEST_IF(IsD3D11_FL93()); ANGLE_SKIP_TEST_IF(IsD3D11_FL93());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment