Commit f8e8fcf8 by Corentin Wallez Committed by Commit Bot

Suppress crashing perftests on Win Intel Exp Rel

Also moves ANGLE_SKIP_TEST_IF to a header shared between end2end and perf tests. BUG=chromium:997674 Change-Id: I7c5968e6d861c4bff703ddc6ae0e4e021e47061f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1768374 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 7f00d338
......@@ -12,6 +12,8 @@
#include "test_utils/draw_call_perf_utils.h"
#include "util/shader_utils.h"
using namespace angle;
namespace
{
enum class StateChange
......@@ -326,6 +328,8 @@ void DrawCallPerfBenchmark::drawBenchmark()
TEST_P(DrawCallPerfBenchmark, Run)
{
// TODO(crbug.com/997674) crashes on Win10 FYI x64 Exp Release (Intel HD 630)
ANGLE_SKIP_TEST_IF(IsWindows() && IsIntel());
run();
}
......
......@@ -204,6 +204,8 @@ LinkProgramParams LinkProgramVulkanParams(TaskOption taskOption, ThreadOption th
TEST_P(LinkProgramBenchmark, Run)
{
// TODO(crbug.com/997674) crashes on Win10 FYI x64 Exp Release (Intel HD 630)
ANGLE_SKIP_TEST_IF(IsWindows() && IsIntel());
run();
}
......
......@@ -567,6 +567,8 @@ MultiviewPerfParams SelectViewInVertexShader(const EGLPlatformParameters &eglPar
TEST_P(MultiviewCPUBoundBenchmark, Run)
{
// TODO(crbug.com/997674) crashes on Win10 FYI x64 Exp Release (Intel HD 630)
ANGLE_SKIP_TEST_IF(IsWindows() && IsIntel());
run();
}
......
......@@ -500,6 +500,8 @@ UniformsParams MatrixUniforms(const EGLPlatformParameters &egl,
TEST_P(UniformsBenchmark, Run)
{
// TODO(crbug.com/997674) crashes on Win10 FYI x64 Exp Release (Intel HD 630)
ANGLE_SKIP_TEST_IF(IsWindows() && IsIntel());
run();
}
......
......@@ -574,14 +574,4 @@ bool IsGLExtensionRequestable(const std::string &extName);
extern angle::PlatformMethods gDefaultPlatformMethods;
#define ANGLE_SKIP_TEST_IF(COND) \
do \
{ \
if (COND) \
{ \
std::cout << "Test skipped: " #COND "." << std::endl; \
return; \
} \
} while (0)
#endif // ANGLE_TESTS_ANGLE_TEST_H_
......@@ -139,4 +139,14 @@ extern std::string gSelectedConfig;
extern bool gSeparateProcessPerConfig;
} // namespace angle
#define ANGLE_SKIP_TEST_IF(COND) \
do \
{ \
if (COND) \
{ \
std::cout << "Test skipped: " #COND "." << std::endl; \
return; \
} \
} while (0)
#endif // ANGLE_TEST_INSTANTIATE_H_
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment