Skip to content

A
angle
Commit f93cc8bd by Tim Van Patten Committed by Commit Bot
Options

Vulkan: Skip failing BlendIntegerTest tests

Several BlendIntegerTest tests are failing due to an update to the Vulkan Validation Layers that are now checking if formats support VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT and generating an error if not while pipeline.pColorBlendState.pAttachments[0].blendEnable is VK_TRUE. Bug: angleproject:4571 Test: BlendIntegerTest* Change-Id: Ibbfe415af3d6d6a879a502adb6541a5bfe8cd13a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152947Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
parent aefa3aa9
Showing with 38 additions and 0 deletions
src/tests/gl_tests/BlendIntegerTest.cpp
...@@ -114,97 +114,135 @@ class BlendIntegerTest : public ANGLETest ...@@ -114,97 +114,135 @@ class BlendIntegerTest : public ANGLETest
// Test that blending is not applied to signed integer attachments. // Test that blending is not applied to signed integer attachments.
TEST_P(BlendIntegerTest, R8I) TEST_P(BlendIntegerTest, R8I)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_R8I, 1, true>(); runTest<GL_R8I, 1, true>();
} }
TEST_P(BlendIntegerTest, R16I) TEST_P(BlendIntegerTest, R16I)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_R16I, 1, true>(); runTest<GL_R16I, 1, true>();
} }
TEST_P(BlendIntegerTest, R32I) TEST_P(BlendIntegerTest, R32I)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_R32I, 1, true>(); runTest<GL_R32I, 1, true>();
} }
TEST_P(BlendIntegerTest, RG8I) TEST_P(BlendIntegerTest, RG8I)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RG8I, 2, true>(); runTest<GL_RG8I, 2, true>();
} }
TEST_P(BlendIntegerTest, RG16I) TEST_P(BlendIntegerTest, RG16I)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RG16I, 2, true>(); runTest<GL_RG16I, 2, true>();
} }
TEST_P(BlendIntegerTest, RG32I) TEST_P(BlendIntegerTest, RG32I)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RG32I, 2, true>(); runTest<GL_RG32I, 2, true>();
} }
TEST_P(BlendIntegerTest, RGBA8I) TEST_P(BlendIntegerTest, RGBA8I)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RGBA8I, 4, true>(); runTest<GL_RGBA8I, 4, true>();
} }
TEST_P(BlendIntegerTest, RGBA16I) TEST_P(BlendIntegerTest, RGBA16I)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RGBA16I, 4, true>(); runTest<GL_RGBA16I, 4, true>();
} }
TEST_P(BlendIntegerTest, RGBA32I) TEST_P(BlendIntegerTest, RGBA32I)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RGBA32I, 4, true>(); runTest<GL_RGBA32I, 4, true>();
} }
// Test that blending is not applied to unsigned integer attachments. // Test that blending is not applied to unsigned integer attachments.
TEST_P(BlendIntegerTest, R8UI) TEST_P(BlendIntegerTest, R8UI)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_R8UI, 1, false>(); runTest<GL_R8UI, 1, false>();
} }
TEST_P(BlendIntegerTest, R16UI) TEST_P(BlendIntegerTest, R16UI)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_R16UI, 1, false>(); runTest<GL_R16UI, 1, false>();
} }
TEST_P(BlendIntegerTest, R32UI) TEST_P(BlendIntegerTest, R32UI)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_R32UI, 1, false>(); runTest<GL_R32UI, 1, false>();
} }
TEST_P(BlendIntegerTest, RG8UI) TEST_P(BlendIntegerTest, RG8UI)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RG8UI, 2, false>(); runTest<GL_RG8UI, 2, false>();
} }
TEST_P(BlendIntegerTest, RG16UI) TEST_P(BlendIntegerTest, RG16UI)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RG16UI, 2, false>(); runTest<GL_RG16UI, 2, false>();
} }
TEST_P(BlendIntegerTest, RG32UI) TEST_P(BlendIntegerTest, RG32UI)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RG32UI, 2, false>(); runTest<GL_RG32UI, 2, false>();
} }
TEST_P(BlendIntegerTest, RGBA8UI) TEST_P(BlendIntegerTest, RGBA8UI)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RGBA8UI, 4, false>(); runTest<GL_RGBA8UI, 4, false>();
} }
TEST_P(BlendIntegerTest, RGBA16UI) TEST_P(BlendIntegerTest, RGBA16UI)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RGBA16UI, 4, false>(); runTest<GL_RGBA16UI, 4, false>();
} }
TEST_P(BlendIntegerTest, RGBA32UI) TEST_P(BlendIntegerTest, RGBA32UI)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RGBA32UI, 4, false>(); runTest<GL_RGBA32UI, 4, false>();
} }
TEST_P(BlendIntegerTest, RGB10_A2UI) TEST_P(BlendIntegerTest, RGB10_A2UI)
{ {
// TODO(http://anglebug.com/4571)
ANGLE_SKIP_TEST_IF(isVulkanRenderer());
runTest<GL_RGB10_A2UI, 4, false>(); runTest<GL_RGB10_A2UI, 4, false>();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment