Commit fb074dd8 by Jamie Madill

Revert "Clear image descs on Impl errors."

Didn't fix the crash, and the crash experiment is complete. BUG=485543 This reverts commit 96748507. Change-Id: If7d97901b87506bf306ab5558575d0413c76cb68 Reviewed-on: https://chromium-review.googlesource.com/272150Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Tested-by: 's avatarJamie Madill <jmadill@chromium.org>
parent fd3b9be6
...@@ -170,8 +170,6 @@ Error Texture::setImage(GLenum target, size_t level, GLenum internalFormat, cons ...@@ -170,8 +170,6 @@ Error Texture::setImage(GLenum target, size_t level, GLenum internalFormat, cons
Error error = mTexture->setImage(target, level, internalFormat, size, format, type, unpack, pixels); Error error = mTexture->setImage(target, level, internalFormat, size, format, type, unpack, pixels);
if (error.isError()) if (error.isError())
{ {
// May be broken at the impl level
clearImageDescs();
return error; return error;
} }
...@@ -198,8 +196,6 @@ Error Texture::setCompressedImage(GLenum target, size_t level, GLenum internalFo ...@@ -198,8 +196,6 @@ Error Texture::setCompressedImage(GLenum target, size_t level, GLenum internalFo
Error error = mTexture->setCompressedImage(target, level, internalFormat, size, unpack, pixels); Error error = mTexture->setCompressedImage(target, level, internalFormat, size, unpack, pixels);
if (error.isError()) if (error.isError())
{ {
// May be broken at the impl level
clearImageDescs();
return error; return error;
} }
...@@ -226,8 +222,6 @@ Error Texture::copyImage(GLenum target, size_t level, const Rectangle &sourceAre ...@@ -226,8 +222,6 @@ Error Texture::copyImage(GLenum target, size_t level, const Rectangle &sourceAre
Error error = mTexture->copyImage(target, level, sourceArea, internalFormat, source); Error error = mTexture->copyImage(target, level, sourceArea, internalFormat, source);
if (error.isError()) if (error.isError())
{ {
// May be broken at the impl level
clearImageDescs();
return error; return error;
} }
...@@ -254,8 +248,6 @@ Error Texture::setStorage(GLenum target, size_t levels, GLenum internalFormat, c ...@@ -254,8 +248,6 @@ Error Texture::setStorage(GLenum target, size_t levels, GLenum internalFormat, c
Error error = mTexture->setStorage(target, levels, internalFormat, size); Error error = mTexture->setStorage(target, levels, internalFormat, size);
if (error.isError()) if (error.isError())
{ {
// May be broken at the impl level
clearImageDescs();
return error; return error;
} }
...@@ -274,8 +266,6 @@ Error Texture::generateMipmaps() ...@@ -274,8 +266,6 @@ Error Texture::generateMipmaps()
Error error = mTexture->generateMipmaps(getSamplerState()); Error error = mTexture->generateMipmaps(getSamplerState());
if (error.isError()) if (error.isError())
{ {
// May be broken at the impl level
clearImageDescs();
return error; return error;
} }
......
...@@ -78,8 +78,7 @@ TextureD3D::TextureD3D(RendererD3D *renderer) ...@@ -78,8 +78,7 @@ TextureD3D::TextureD3D(RendererD3D *renderer)
mUsage(GL_NONE), mUsage(GL_NONE),
mDirtyImages(true), mDirtyImages(true),
mImmutable(false), mImmutable(false),
mTexStorage(NULL), mTexStorage(NULL)
mTriedToInitIncompleteStorage(false)
{ {
} }
...@@ -1074,8 +1073,6 @@ gl::Error TextureD3D_2D::initializeStorage(bool renderTarget) ...@@ -1074,8 +1073,6 @@ gl::Error TextureD3D_2D::initializeStorage(bool renderTarget)
// do not attempt to create storage for nonexistant data // do not attempt to create storage for nonexistant data
if (!isLevelComplete(0)) if (!isLevelComplete(0))
{ {
// TODO(jmadill): remove this debugging code after we fix the bug
mTriedToInitIncompleteStorage = true;
return gl::Error(GL_NO_ERROR); return gl::Error(GL_NO_ERROR);
} }
......
...@@ -103,10 +103,6 @@ class TextureD3D : public TextureImpl ...@@ -103,10 +103,6 @@ class TextureD3D : public TextureImpl
bool mImmutable; bool mImmutable;
TextureStorage *mTexStorage; TextureStorage *mTexStorage;
// TODO(jmadill): remove this debugging code after we fix the bug
friend class Renderer11;
bool mTriedToInitIncompleteStorage;
private: private:
virtual gl::Error initializeStorage(bool renderTarget) = 0; virtual gl::Error initializeStorage(bool renderTarget) = 0;
......
...@@ -791,15 +791,7 @@ gl::Error Renderer11::setSamplerState(gl::SamplerType type, int index, gl::Textu ...@@ -791,15 +791,7 @@ gl::Error Renderer11::setSamplerState(gl::SamplerType type, int index, gl::Textu
// Storage should exist, texture should be complete // Storage should exist, texture should be complete
ASSERT(storage); ASSERT(storage);
// TODO(jmadill): remove this debugging code after we fix the bug samplerStateInternal.baseLevel += storage->getTopLevel();
if (!storage && textureD3D->mTriedToInitIncompleteStorage)
{
samplerStateInternal.baseLevel += storage->getTopLevel();
}
else
{
samplerStateInternal.baseLevel += storage->getTopLevel();
}
if (type == gl::SAMPLER_PIXEL) if (type == gl::SAMPLER_PIXEL)
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment