Commit fb44e93b by Jonah Ryan-Davis Committed by Commit Bot

Disable TransformFeedbackTest.NonExistentTransformFeedback*

This test hase begun failing consistently on the Arm based Apple DTK. This adds a skip to the test for that config. Test: TransformFeedbackTest.NonExistentTransformFeedbackVaryingWithGLPrefix:/ES3_OpenGL Bug: chromium:1140113 Change-Id: I97612a073db20c99883908a19ac0013101061da0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486100Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
parent 188a1fc7
...@@ -1528,6 +1528,9 @@ TEST_P(TransformFeedbackTest, NonExistentTransformFeedbackVarying) ...@@ -1528,6 +1528,9 @@ TEST_P(TransformFeedbackTest, NonExistentTransformFeedbackVarying)
// nonexistent varying is prefixed with "gl_". // nonexistent varying is prefixed with "gl_".
TEST_P(TransformFeedbackTest, NonExistentTransformFeedbackVaryingWithGLPrefix) TEST_P(TransformFeedbackTest, NonExistentTransformFeedbackVaryingWithGLPrefix)
{ {
// TODO(crbug.com/1132295): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
std::vector<std::string> tfVaryings; std::vector<std::string> tfVaryings;
tfVaryings.push_back("gl_Bogus"); tfVaryings.push_back("gl_Bogus");
...@@ -1630,6 +1633,7 @@ TEST_P(TransformFeedbackTest, SwitchProgramBeforeDraw) ...@@ -1630,6 +1633,7 @@ TEST_P(TransformFeedbackTest, SwitchProgramBeforeDraw)
{ {
// TODO(crbug.com/1132295): Failing on ARM-based Apple DTKs. // TODO(crbug.com/1132295): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
std::vector<std::string> tfVaryings; std::vector<std::string> tfVaryings;
tfVaryings.push_back("gl_Position"); tfVaryings.push_back("gl_Position");
compileDefaultProgram(tfVaryings, GL_INTERLEAVED_ATTRIBS); compileDefaultProgram(tfVaryings, GL_INTERLEAVED_ATTRIBS);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment