Skip to content

A
angle
Commit fb5c581d by Jamie Madill Committed by Commit Bot
Options

Functional revert of "Signal different dirty bit for vertex buffer change."

Seems to be causing rendering regressions in the Google Maps benchmark. Likely causing other serious regressions. Original CL: https://chromium-review.googlesource.com/c/angle/angle/+/1684294 Bug: angleproject:3256 Change-Id: I41608a3ce3c3267097b4c1c0a6f7450cf8a2f48f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1709756Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 765ee7b7
Showing with 14 additions and 9 deletions
src/libANGLE/VertexArray.cpp
...@@ -477,15 +477,20 @@ ANGLE_INLINE void VertexArray::setVertexAttribPointerImpl(const Context *context ...@@ -477,15 +477,20 @@ ANGLE_INLINE void VertexArray::setVertexAttribPointerImpl(const Context *context
attrib.pointer = pointer; attrib.pointer = pointer;
attrib.vertexAttribArrayStride = stride; attrib.vertexAttribArrayStride = stride;
if (bindVertexBufferImpl(context, attribIndex, boundBuffer, offset, effectiveStride) && // "Pointer buffer" dirty bit disabled because of a bug. http://anglebug.com/3256
!attribDirty) bindVertexBufferImpl(context, attribIndex, boundBuffer, offset, effectiveStride);
{ setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER);
setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER_BUFFER); ANGLE_UNUSED_VARIABLE(attribDirty);
}
else if (attribDirty) // if (bindVertexBufferImpl(context, attribIndex, boundBuffer, offset, effectiveStride) &&
{ // !attribDirty)
setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER); //{
} // setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER_BUFFER);
//}
// else if (attribDirty)
//{
// setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER);
//}
mState.mNullPointerClientMemoryAttribsMask.set(attribIndex, mState.mNullPointerClientMemoryAttribsMask.set(attribIndex,
boundBuffer == nullptr && pointer == nullptr); boundBuffer == nullptr && pointer == nullptr);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment