Enable "-Wtautological-type-limit-compare".

This is used by Skia. It seems like a good this to enable in any case. It verifies that we don't do pointless comparisons like "int < INTMAX". Fix the one instance by using the base checked numeric helpers. Bug: angleproject:4046 Change-Id: Ie14a9cb2754df52929591281062d92ef70df8f97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877474Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Enable "-Wtautological-type-limit-compare".
fd58d22c · Jamie Madill · Commit Bot · 3db80f93 · fd58d22c · fd58d22c
Commit fd58d22c authored Oct 24, 2019 by Jamie Madill Committed by Commit Bot Oct 25, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

BUILD.gn BUILD.gn +1 -0

utilities.cpp src/common/utilities.cpp +1 -1

No files found.
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -140,6 +140,7 @@ config("extra_warnings") {
      "-Wextra-semi-stmt",
      "-Wfloat-conversion",
      "-Wnon-virtual-dtor",
+      "-Wtautological-type-limit-compare",
      "-Wunneeded-internal-declaration",
      # The below warnings are used by WebKit. We enable them to make rolling

--- a/src/common/utilities.cpp
+++ b/src/common/utilities.cpp
@@ -883,7 +883,7 @@ unsigned int ParseArrayIndex(const std::string &name, size_t *nameLengthWithoutA
                strtoul(name.c_str() + open + 1, /*endptr*/ nullptr, /*radix*/ 10);
            // Check if resulting integer is out-of-range or conversion error.
-            if ((subscript <= static_cast<unsigned long>(UINT_MAX)) &&
+            if (angle::base::IsValueInRangeForNumericType<uint32_t>(subscript) &&
                !(subscript == ULONG_MAX && errno == ERANGE) && !(errno != 0 && subscript == 0))
            {
                *nameLengthWithoutArrayIndexOut = open;