D3D11: Add null check to Renderer11::testDeviceLost.

After experiencing a device loss, Renderer11::resetDevice can fail to recreate mDevice, leaving it null. In a following call to testDeviceLost, mDevice will be dereferenced, causing a segfault. BUG=angleproject:1457 Change-Id: Ib5be64542929441ceb7088a328c3245ae7e52f17 Reviewed-on: https://chromium-review.googlesource.com/364120Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>

D3D11: Add null check to Renderer11::testDeviceLost.
fde9d8c1 · Edwin Flores · Commit Bot · 9aa83fe3 · fde9d8c1 · fde9d8c1
Commit fde9d8c1 authored Jul 28, 2016 by Edwin Flores Committed by Commit Bot Sep 29, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

CONTRIBUTORS CONTRIBUTORS +1 -0

Renderer11.cpp src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp +5 -0

No files found.
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -74,6 +74,7 @@ Klarälvdalens Datakonsult AB

 Mozilla Corp.
 Ehsan Akhgari
+ Edwin Flores
 Jeff Gilbert
 Mike Hommey
 Benoit Jacob

--- a/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp
+++ b/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp
@@ -2573,6 +2573,11 @@ bool Renderer11::testDeviceLost()
 {
    bool isLost = false;

+    if (!mDevice)
+    {
+        return true;
+    }
+
    // GetRemovedReason is used to test if the device is removed
    HRESULT result = mDevice->GetDeviceRemovedReason();
    isLost = d3d11::isDeviceLostError(result);