Fix useless move() in SizedMRUCache_unittest.cpp

Drop std::move() calls in places where there's no actual moving happing, and only the "bugprone-use-after-move" clang-tidy warning is triggered. Bug: chromium:1122844 Change-Id: I692da5af4f96305f09008d1c7fd18f9be7f6273f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2401241 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Fix useless move() in SizedMRUCache_unittest.cpp
fe822457 · Maksim Ivanov · Commit Bot · d29d4c6b · fe822457
Commit fe822457 authored Sep 10, 2020 by Maksim Ivanov Committed by Commit Bot Sep 10, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

SizedMRUCache_unittest.cpp src/libANGLE/SizedMRUCache_unittest.cpp +4 -2

No files found.
--- a/src/libANGLE/SizedMRUCache_unittest.cpp
+++ b/src/libANGLE/SizedMRUCache_unittest.cpp
@@ -53,7 +53,8 @@ TEST(SizedMRUCacheTest, ManySmallValues)

    for (size_t value = 0; value < kSize; ++value)
    {
-        EXPECT_TRUE(sizedCache.put(value, std::move(value), 1));
+        size_t valueCopy = value;
+        EXPECT_TRUE(sizedCache.put(value, std::move(valueCopy), 1));

        const size_t *qvalue = nullptr;
        EXPECT_TRUE(sizedCache.get(value, &qvalue));
@@ -90,7 +91,8 @@ TEST(SizedMRUCacheTest, ManySmallValues)
    // Put a bunch of items in the cache sequentially.
    for (size_t value = 0; value < kSize * 10; ++value)
    {
-        EXPECT_TRUE(sizedCache.put(value, std::move(value), 1));
+        size_t valueCopy = value;
+        EXPECT_TRUE(sizedCache.put(value, std::move(valueCopy), 1));
    }

    EXPECT_EQ(32u, sizedCache.size());