Vulkan: Warn for unsupported vertex attrib format

Provide both a performance warning and a debug-util label (for AGI) when loading a vertex attribute requires a format conversion. Bug: b/184355822 Change-Id: Id8cbb34f70214327e1f5cc96559e4ea66dc17889 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2801154 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>

Vulkan: Warn for unsupported vertex attrib format
fedb85b7 · Ian Elliott · Commit Bot · 795d7543 · fedb85b7
Commit fedb85b7 authored Apr 07, 2021 by Ian Elliott Committed by Commit Bot Apr 10, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 0 deletions

VertexArrayVk.cpp src/libANGLE/renderer/vulkan/VertexArrayVk.cpp +11 -0

No files found.
--- a/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
+++ b/src/libANGLE/renderer/vulkan/VertexArrayVk.cpp
@@ -578,6 +578,17 @@ angle::Result VertexArrayVk::syncDirtyAttrib(ContextVk *contextVk,
            if (vertexFormat.getVertexLoadRequiresConversion(compressed) || !bindingIsAligned)
            {
+                if (vertexFormat.getVertexLoadRequiresConversion(compressed))
+                {
+                    std::ostringstream stream;
+                    stream << "The Vulkan driver does not support the 0x" << std::hex
+                           << vertexFormat.intendedFormat().glInternalFormat
+                           << " vertex attribute format; emulating with 0x"
+                           << vertexFormat.actualBufferFormat(compressed).glInternalFormat;
+                    ANGLE_PERF_WARNING(contextVk->getDebug(), GL_DEBUG_SEVERITY_LOW,
+                                       stream.str().c_str());
+                    ANGLE_TRY(contextVk->insertEventMarker(0, stream.str().c_str()));
+                }
                ConversionBuffer *conversion = bufferVk->getVertexConversionBuffer(
                    renderer, intendedFormat.id, binding.getStride(),
                    binding.getOffset() + attrib.relativeOffset, !bindingIsAligned);