- 06 Feb, 2020 5 commits
-
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/260679605f98..428455ca6121 git log 260679605f98..428455ca6121 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 timo.gurr@gmail.com vkcube: fix unknown CMake command error 2020-01-31 shannon@lunarg.com build: Update known-good for 1.2.132 header Created with: gclient setdep -r third_party/vulkan-tools/src@428455ca6121 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ibb125e6cfecda694041c7aa83998c6510d5f7e0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041074Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8e8e1d0dd729..dd48b7e2d06e git log 8e8e1d0dd729..dd48b7e2d06e --date=short --first-parent --format='%ad %ae %s' 2020-02-05 amaiorano@google.com Fix MSAN LLVM jit false positives 2020-02-05 bclayton@google.com Disable new gcc 9 warning [init-list-lifetime] Created with: gclient setdep -r third_party/SwiftShader@dd48b7e2d06e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I75bcfe8bc85d98104835ab9740c3c3f7c267e9fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2041077Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Shahbaz Youssefi authored
Since line raster emulation was changed to use specialization constants, it has been possible to compile shaders at link time. However, program pipeline objects would have required keeping the shader sources around for recompilation. Now that all necessary decorations are modified directly in SPIR-V, it's possible to compile the shaders at link time and forget about their sources. Program pipeline objects then simply "reconfigure" the generated SPIR-V. A next step could be to also create the Vulkan pipeline object at link time. A number of failures due to gaps in CTS testing prevent that work currently. In particular, in some situations the generated SPIR-V is not per spec, for example it may contain vertex attributes with aliasing locations, or have transform feedback capture of array elements misconfigured. Bug: angleproject:3394 Bug: angleproject:4253 Change-Id: I54c0884cf056b511a4a306225cc6ed2cef84d257 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023186 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Also fixes the missing RenderPass count in the new command recorder. Bug: angleproject:4029 Change-Id: If7f0cf9e80ef815781ad2684ad1d93a3ed4912ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2037786Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tobin Ehlis <tobine@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Implements queries with the new command graph syntax. The T-Rex capture benchmark uses queries so this fixes several errors. Bug: angleproject:4029 Change-Id: Ia785f8e31257116aa3c75032dd66471b49926a78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2021003 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tobin Ehlis <tobine@google.com>
-
- 05 Feb, 2020 11 commits
-
-
Jamie Madill authored
ES 2.0 is feature complete. Passes all of the angle_end2end_tests with the new linear command recording method. Also runs the T-Rex benchmark without any obvious glitches. Likely has issues with creating too many RenderPasses. ES3 is mostly untouched. Bug: angleproject:4029 Change-Id: Ic5acf3d768495fbffd07b07bf0a6f2b5787c51f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2012900Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jonah Ryan-Davis authored
Implement an IOSurface-backed pBuffer surface for the Vulkan backend on Mac, through SwANGLE. ANGLE will pass a raw pointer to Swiftshader and handle locking/unlocking the IOSurface. Bug: chromium:1015454 Change-Id: Ia3ead55334736003d405b54ba8dcc7701706fbb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965434 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Julien Isorce authored
This CL is intended to move and factorize code only. Move DisplayAndroid::generateConfigs to DisplayEGL::generateConfigs because the code is generic and not Android specific. It will be useful later to provide a default implementation of rx::DisplayEGL. Same for createWindowSurface and createPbufferSurface, they have been moved without changes from DisplayAndroid to DisplayEGL. Unimplemented functions in DisplayOzone and DisplayAndroid have been moved to DisplayEGL. Bug: angleproject:4328 Change-Id: Ibbd36f99ea457cbd69391beb4a83f23403bc40fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038286 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com>
-
Alexey Knyazev authored
Bug: angleproject:4266 Change-Id: I70b3cdef35395b3a92bd460c9911b1ed963e0dcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038573 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Allows the application to override ANGLE behaviour without having to modify the code or use the ANGLE extension. Useful for testing with the command graph refactor. Adds a new string utility for parsing lists of strings from environment variables. Bug: angleproject:4029 Change-Id: Ibae93b743c0c385392cd259d9604ce2f2ed988dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2037784Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/540662253ea3..b82ed734e767 Created with: gclient setdep -r third_party/glslang/src@b82ed734e767 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I74671608ecc264f49611e82a3c9ef0a3e4930b9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038127Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/807f14657a25..b932cf53f769 git log 807f14657a25..b932cf53f769 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 lenny@lunarg.com loader: Add core 1.2 functions to gpa_helper 2020-02-04 charles@lunarg.com loader: add null check to loaderValidateLayers 2020-02-04 charles@lunarg.com loader: Warn when loader_secure_getenv() fails Created with: gclient setdep -r third_party/vulkan-loader/src@b932cf53f769 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I6b37613fe780e0d146def7885657b17495b1c93f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038120Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/41a7302e9c62..8e8e1d0dd729 git log 41a7302e9c62..8e8e1d0dd729 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 bclayton@google.com Shader: Add missing switch cases to operationString 2020-02-04 bclayton@google.com OpenGL: Fix switch with only a default case. 2020-02-04 amaiorano@google.com Regres: fix no env-vars for deqp on Windows 2020-02-04 lfy@google.com android: avoid exporting normal Vulkan APIs Created with: gclient setdep -r third_party/SwiftShader@8e8e1d0dd729 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ia9ff11bbc842f324e2b65745fd6647cede0ba138 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038122Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e85fe4c3cc9f..ab47cacfd3b3 git log e85fe4c3cc9f..ab47cacfd3b3 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 tony@lunarg.com gpu: Use updated interface to instrumentation Created with: gclient setdep -r third_party/vulkan-validation-layers/src@ab47cacfd3b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Icfbd19b525474b1d3aabe96bb741c5f30c856af1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038176Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7a2d408dea60..9e52bc0d0c1d Created with: gclient setdep -r third_party/spirv-tools/src@9e52bc0d0c1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ie6f6f11d84983936e736d7293c5e48d7add4d24e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038121Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Shahbaz Youssefi authored
This change breaks the assumption everywhere that varyings can be identified uniquely by name throughout all stages of the pipeline. It further implements linking of varyings by location, if specified. Bug: angleproject:4355 Change-Id: Ie45e48879008c3f0c22d1da3d0d26f37c655e54e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2030026 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
- 04 Feb, 2020 7 commits
-
-
Alexey Knyazev authored
gl.xml was modified as two enums were missing from their proper group. dxgi_support_data.json was fixed to not expect BC4 and BC5 on FL9_3 Bug: angleproject:3149 Change-Id: Ieb97a8cf8e92258c1b44e090e823fac227997174 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033068Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org>
-
Cody Northrop authored
Rather than try to read back compressed data using ANGLE_get_image (which does not yet support compressed formats), track a shadow copy of the compressed image and store it like client data. Test: Mid-execution capture and replay of TRex frames using ETC1 Bug: angleproject:4036 Change-Id: Id15be60f7444cc2e1356e76ff18069c42e552663 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2015818Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Jamie Madill authored
Useful debugging information for benchmarks. Also helpful when working with the command graph to ensure we don't regress performance. Bug: angleproject:4029 Bug: angleproject:4320 Change-Id: Ibe224c40a3acaca9231bf3869486a0f8bba07ba0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2036402Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Tobin Ehlis <tobine@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Alexey Knyazev authored
Bug: angleproject:4372 Change-Id: Ic1800ac10b12547ca9816f7ad9dfd62f83f227c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033066 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org>
-
Alexey Knyazev authored
Added avoid_dxt1_srgb_texture_format workaround Bug: angleproject:4266 Change-Id: I286a9c66f6ea1d2c9d3587f6ca85608336eb44a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033065Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/fb94ccddb725..807f14657a25 git log fb94ccddb725..807f14657a25 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 lenny@lunarg.com build: Regenerate files for debug utils changes 2020-02-03 lenny@lunarg.com loader: Fix debug utils terminators being skipped Created with: gclient setdep -r third_party/vulkan-loader/src@807f14657a25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I85fda88b6f1cb17e1e9bae96431471a77d6f73ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2036416Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5e86b28ffb81..540662253ea3 Created with: gclient setdep -r third_party/glslang/src@540662253ea3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I42d8f32fdc6b12dff781f426a7c099458f556056 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2036425Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 03 Feb, 2020 5 commits
-
-
Geoff Lang authored
The Display now owns scratch buffers and loans them out to contexts while they are current. This allows us to to only allocate one scratch buffer in a single-threaded use case. Tick the scratch buffers every time a new context is made current. Lower the lifetime from 1000 to 64 to ensure that in the worst case, the buffers are cleared after not being used for ~1 second. BUG=chromium:1030835 BUG=angleproject:4363 Change-Id: I83552424e2beac62b9e41152876b04fc84f53692 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2031698 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org>
-
Tibor Dusnoki authored
There are multiple failing tests on Windows on ARM which are related to drawing differences. They seem to be similar to an already reported issue (anglebug.com/3748). Bug: angleproject:4356 Bug: angleproject:4357 Change-Id: Ide5cc2e6f42d4c4b6fb88352833d20e517005c14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033067 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bd4b3a888fca..e85fe4c3cc9f git log bd4b3a888fca..e85fe4c3cc9f --date=short --first-parent --format='%ad %ae %s' 2020-01-31 s.fricke@samsung.com tests: Added tests for Ycbcr in vkCreateImage 2020-01-31 s.fricke@samsung.com layers: Added Ycbcr support in VkImageCreateInfo 2020-01-31 tony@lunarg.com layers: Use safe_VkImageCreateInfos Created with: gclient setdep -r third_party/vulkan-validation-layers/src@e85fe4c3cc9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I7c9dc2a0b4aed5232065fa44edda034cd72d9f6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2035158Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/79b36b640692..41a7302e9c62 git log 79b36b640692..41a7302e9c62 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 capn@google.com Split JIT creation from LLVMReactor.cpp into LLVMJIT.cpp 2020-01-31 bclayton@google.com CMake: Add build rules for google benchmark. 2020-01-31 bclayton@google.com Add google benchmark submodule to third_party. Created with: gclient setdep -r third_party/SwiftShader@41a7302e9c62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: I4d800b6768fae30052cbc2ca56e42973b1756ad5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2035159Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Charlie Lao authored
The spec doesn't require implementation to validate indices against range. This extra validation is costing performance dearly, thus should be removed. Bug: angleproject:4373 Change-Id: I61b0628e75de368d9e869008b7c99c429222fd6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033495Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
-
- 01 Feb, 2020 5 commits
-
-
Shahbaz Youssefi authored
Some features were used but not enabled. There is no validation error for this. This change enables the following features: - shaderStorageBufferArrayDynamicIndexing: used by atomic counter emulation. - shaderSampledImageArrayDynamicIndexing: used by sampler array of array emulation, as well EXT_gpu_shader5. - shaderUniformBufferArrayDynamicIndexing: used by EXT_gpu_shader5. Bug: angleproject:4071 Change-Id: I582750d1552055deeec50485e6511788b98490c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032144Reviewed-by:
Tobin Ehlis <tobine@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Kenneth Russell authored
It's causing flaky crashes in tests. Leave the revised code in place so it's easier to debug. Disable test which required the workaround. Bug: angleproject:2273 Bug: angleproject:3843 Change-Id: Iebb682bd3c6282031cc57eda5d3d4d5636be7294 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033870 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org>
-
Michael Spang authored
This avoids a deprecation warning: [01253.076] [WARNING:src/ui/bin/root_presenter/app.cc(109)] Using multiple presentations is deprecated. Call PresentOrReplaceView() to force replacement of current presentation. Bug: angleproject:4360 Change-Id: Icb1898ee542bde8c26a2dcd55c783372fc8ae7c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027935 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Michael Spang authored
The test suite occasionally runs into the following error: [02036.794449][326733][326738][klog] INFO: [ERROR:src/ui/scenic/lib/scenic/session.cc(412)] Scenic session error (session_id: 1): Present2() called with no more present calls allowed. Terminating session. This is actually a problem with the test harness as resetting the window triggers a present with no fences and no OnFramePresentedCallback which means there is no way to know if we will exceed the limit. Add an OnFramePresentedCallback and count presents to stay under the limit. This blocks if there's more than 2 in flight presents. A dedicated async loop is used to avoid re-entering other code while waiting to present (there is no such case in the ANGLE test suite currently, but better safe than sorry). Typically if we run the whole suite there will be a failure in the middle, but re-trying the test that failed won't repro the issue. Add a test that reliably exhausts the limit by calling resetNativeWindow() in a loop. Bug: angleproject:4360 Change-Id: I24eb01fd72fc0be57c36e49b5875023a80d6ab91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027934 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Geoff Lang authored
Not all call sites were checking the return value of MemoryBuffer::resize, mark the return value as NO_DISCARD and fix all the warnings. BUG=chromium:1030835 Change-Id: I762796e3d11efc131a814069d78a195b0d4c9f8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2028151 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- 31 Jan, 2020 7 commits
-
-
Tobin Ehlis authored
We no longer need this workaround. Also mCommandPoolFreeList dead code. Bug: angleproject:3508 Change-Id: Ib73ddd431eb1bf9a55c3421111af4df5976cc1fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033485Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tobin Ehlis <tobine@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8317b28e672a..bd4b3a888fca git log 8317b28e672a..bd4b3a888fca --date=short --first-parent --format='%ad %ae %s' 2020-01-31 tobine@google.com build: Add NOMINMAX to Win ninja build 2020-01-30 mark@lunarg.com build: Move NOMINMAX definition from src to cmake file 2020-01-29 shannon@lunarg.com build: Update known-good for 1.2.132 header 2020-01-28 tony@lunarg.com layers: Fix call to overwrite_range 2020-01-28 s.fricke@samsung.com tests: Added test for VUID 02283 2020-01-28 s.fricke@samsung.com layers: Added VUID 02283 2020-01-28 tony@lunarg.com tests: Add test for 02829 and 02830 2020-01-28 tony@lunarg.com layers: Add validation for 02829 and 02830 2020-01-28 s.fricke@samsung.com layers: Removed redundant sType check 2020-01-28 s.fricke@samsung.com layers: Fix shader not looping correctly 2020-01-27 jeremy@lunarg.com tests: Test specialization constant size 2020-01-27 jeremy@lunarg.com layers: Fix specialization constant size 2020-01-27 tony@lunarg.com tests: Better checking for 1.2 2020-01-24 jzulauf@lunarg.com layers: Optimize descriptor allocation 2020-01-23 Andrew.Fobel@amd.com tests: Add tests for VK_EXT_separate_stencil_usage 2020-01-23 Andrew.Fobel@amd.com layers: Add VK_EXT_separate_stencil_usage support 2020-01-23 jzulauf@lunarg.com build: Update copyright header dates for modified 2020-01-23 jzulauf@lunarg.com layers: Bug fix for parallel iterator 2020-01-23 jzulauf@lunarg.com layers: performance tune ImageSubresourceLayoutMap 2020-01-23 jzulauf@lunarg.com layers: implement small range map and wrapper 2020-01-23 jzulauf@lunarg.com layers: Cleanups and fixes from further unit test 2020-01-23 jzulauf@lunarg.com layers: Fix ImageLayoutIntialState tracking 2020-01-23 jzulauf@lunarg.com layers: Add range map view to image_layout 2020-01-23 jzulauf@lunarg.com layers: Apply google style to new image layout impl 2020-01-23 jzulauf@lunarg.com layers: ImageLayout traversal to iterators 2020-01-23 jzulauf@lunarg.com layers: Refactor heavyweight ForRange/Iterator 2020-01-23 jzulauf@lunarg.com layers: New sparse map for image subresource data Created with: gclient setdep -r third_party/vulkan-validation-layers/src@bd4b3a888fca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tobine@google.com Change-Id: Ib96b03f57e54f3e39573482c56cae1a2bd0970a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033407Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Yuly Novikov authored
Also update doc. Bug: angleproject:3928 Change-Id: I1134e1fa9338fa95d647502bf62edb42555caec8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033487Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
Jeff Gilbert authored
Bug: angleproject:4365 Change-Id: I4098ebdd718624e9d0578e0ee69f0a84a5b78183 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033064 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Charlie Lao authored
This workaround was added due to qualcomm driver bug b/129281932. But this has been fixed with recent drivers. Removing the WR here so that it will not negatively affect performance. Bug: angleproject:4344 Change-Id: Iea2ec86082a0ced64bfe843bf916c6bdb2aea60b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2029210 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Tobin Ehlis <tobine@google.com>
-
Cody Northrop authored
Populate the entrypoints required to get gfxBench Manhattan scene to capture and replay correctly from the beginning of the trace. Test: Captured and replayed Manhattan frames 0-500 on both Windows and Linux (Nvidia GPUs) Bug: angleproject:4091 Change-Id: I5447a6835e55e944772d37219f2bd414606f0a70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2029216Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Shahbaz Youssefi authored
Most UtilsVk functions bind a descriptor set to index 0 (same as driver uniforms). If that happens to close a render pass, all is well as starting a new render pass ensures all descriptor sets are rebound. However, if the render pass is not closed, or if a dispatch call is issued (which never rebinds descriptor sets if not explicitly necessary), then the driver uniforms descriptor set may end up never rebound, causing a validation error (and possible crash or corruption). This change makes sure that UtilsVk notifies the context when it binds a descriptor set. The context then dirties the driver uniforms binding as appropriate. Bug: angleproject:4272 Change-Id: Ief20c7884fbe39712f844247489812afc70b30a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027938 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-